Skip to content

Figure.sac: Plot seismograms in SAC format - #4854

Open
Chuan1937 wants to merge 32 commits into
mainfrom
figure-sac
Open

Figure.sac: Plot seismograms in SAC format#4854
Chuan1937 wants to merge 32 commits into
mainfrom
figure-sac

Conversation

@Chuan1937

@Chuan1937 Chuan1937 commented Aug 24, 2026 •
edited by seisman
Loading

Copy link
Copy Markdown
Member

This pull request wraps the module sac.

Preview at https://pygmt-dev--4854.org.readthedocs.build/en/4854/api/generated/pygmt.Figure.sac.html

Related to #4853.

@Chuan1937 Chuan1937 changed the title add base parameters and tests for sac module Figure.sac: Plot seismograms in SAC format Aug 24, 2026
@Chuan1937 Chuan1937 self-assigned this Aug 24, 2026
@Chuan1937 Chuan1937 added the feature Brand new feature label Aug 24, 2026
@Chuan1937 Chuan1937 added this to the 0.20.0 milestone Aug 24, 2026
@Chuan1937
Chuan1937 requested a balanced review from Copilot August 24, 2026 05:06
Copilot AI reviewed Aug 24, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Chuan1937 Chuan1937 mentioned this pull request Aug 24, 2026
Open
13 of 20 tasks
seisman
seisman reviewed Aug 24, 2026
View reviewed changes
Comment thread pygmt/src/sac.py Resolved
Comment thread pygmt/src/sac.py Resolved
Comment thread pygmt/src/sac.py Resolved
Comment thread pygmt/src/sac.py Resolved
Chuan1937 and others added 5 commits August 24, 2026 13:31
@Chuan1937 @seisman
Update pygmt/src/sac.py
f4eb9e7 
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@Chuan1937 @seisman
Update pygmt/src/sac.py
0a9d38d 
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@Chuan1937 @seisman
Update pygmt/src/sac.py
4b8b429 
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@Chuan1937 @seisman
Update pygmt/src/sac.py
55df660 
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@Chuan1937
replace spec with data
05814c5
@Chuan1937
Chuan1937 requested a lite review from Copilot August 24, 2026 06:01
Copilot AI reviewed Aug 24, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.

Comment thread pygmt/src/sac.py Resolved
seisman
seisman reviewed Aug 26, 2026
View reviewed changes
Comment thread pygmt/src/sac.py Resolved
seisman
seisman reviewed Sep 4, 2026
View reviewed changes
Comment thread pygmt/src/sac.py Resolved
seisman
seisman reviewed Sep 7, 2026
View reviewed changes
Comment thread pygmt/src/sac.py Resolved
@Chuan1937 @seisman
Update pygmt/src/sac.py
119eb75 
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
seisman
seisman reviewed Sep 7, 2026
View reviewed changes
Comment thread pygmt/src/sac.py Resolved
Comment thread pygmt/src/sac.py Resolved
Comment thread pygmt/src/sac.py Resolved
Comment thread pygmt/src/sac.py Resolved
seisman
seisman reviewed Sep 7, 2026
View reviewed changes
Comment thread pygmt/src/sac.py Resolved
@Chuan1937 @seisman
Update pygmt/src/sac.py
68bc581 
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Chuan1937 and others added 3 commits September 7, 2026 14:26
@Chuan1937 @seisman
Update pygmt/src/sac.py
6cf82ce 
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@Chuan1937 @seisman
Update pygmt/src/sac.py
dff982e 
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@Chuan1937
make format
2ce8214
seisman
seisman reviewed Sep 7, 2026
View reviewed changes
Comment thread pygmt/src/sac.py Resolved
Comment thread pygmt/src/sac.py Resolved
seisman
seisman reviewed Sep 7, 2026
View reviewed changes
Comment thread pygmt/src/sac.py Resolved
seisman
seisman reviewed Sep 8, 2026
View reviewed changes
Comment thread pygmt/src/sac.py Resolved
Comment thread pygmt/src/sac.py Resolved
Comment thread pygmt/src/sac.py Resolved
Chuan1937 and others added 4 commits September 8, 2026 11:06
@Chuan1937 @seisman
Update pygmt/src/sac.py
066393a 
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@Chuan1937 @seisman
Update pygmt/src/sac.py
7d43d9f 
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@Chuan1937 @seisman
Update pygmt/src/sac.py
4fe57ac 
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@Chuan1937
Fix trace number start parameter
c4da0b7
seisman
seisman reviewed Sep 8, 2026
View reviewed changes
Comment thread pygmt/src/sac.py Resolved
Comment thread pygmt/src/sac.py Resolved
Comment thread pygmt/src/sac.py Resolved
Chuan1937 and others added 2 commits September 8, 2026 12:47
@Chuan1937 @seisman
Update pygmt/src/sac.py
e99a79f 
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@Chuan1937 @seisman
Update pygmt/src/sac.py
d94acb8 
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
seisman
seisman reviewed Sep 8, 2026
View reviewed changes
Comment thread pygmt/src/sac.py Resolved
Comment thread pygmt/src/sac.py Resolved
Chuan1937 and others added 4 commits September 8, 2026 19:07
@Chuan1937 @seisman
Update pygmt/src/sac.py
8bd4d24 
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@Chuan1937 @seisman
Update pygmt/src/sac.py
6350d47 
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@Chuan1937
Merge branch 'main' into figure-sac
1b86308
@Chuan1937
Make SAC preprocess parameter more Pythonic
449e7a1
seisman
seisman reviewed Sep 8, 2026
View reviewed changes
Comment thread pygmt/src/sac.py Resolved
@seisman seisman added the needs review This PR has higher priority and needs review. label Sep 15, 2026
@seisman seisman removed this from the 0.20.0 milestone Oct 22, 2026
@seisman seisman removed the needs review This PR has higher priority and needs review. label Oct 22, 2026
@seisman

seisman commented Oct 28, 2026

Copy link
Copy Markdown
Member

@Chuan1937 Sorry for the late reply. We're planning to release v0.20.0 in a short time, so don't have much time reviewing this PR. We will definitely come back to this feature later.

@Chuan1937

Chuan1937 commented Oct 28, 2026

Copy link
Copy Markdown
Member Author

@Chuan1937 Sorry for the late reply. We're planning to release v0.20.0 in a short time, so don't have much time reviewing this PR. We will definitely come back to this feature later.

ok,I'm always here.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seisman seisman seisman left review comments
@yvonnefroehlich yvonnefroehlich yvonnefroehlich left review comments
Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@Chuan1937 Chuan1937

Labels

feature Brand new feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Chuan1937 @seisman @yvonnefroehlich