Repository navigation
fix(gemini): honor generation settings and add Jsonnet API coverage - #667
Open
QIU-Guanzong wants to merge 1 commit into
Open
QIU-Guanzong wants to merge 1 commit into
QIU-Guanzong wants to merge 1 commit into
Conversation
|
CLA Assistant Lite bot: Thank you for your submission, we really appreciate it. Before we can accept your contribution, we ask that you sign the Arakoo Contributor License Agreement. You can sign the CLA by adding a new comment to this pull request and pasting exactly the following text. I have read the Arakoo CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request |
Author
|
I have read the Arakoo CLA Document and I hereby sign the CLA |
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #279
The existing Gemini client ignores the selected model and sends generation settings as Axios options, so Google never receives them. This fixes the direct HTTP client and completes the Jsonnet example and API tests requested in #279, following the maintainer's clarification to use Gemini without wrapping the Google SDK.
generationConfig, preserving values such astemperature: 0.testcases/palm2and a runnablegemini-chatexample. Prompts and generation settings are evaluated from Jsonnet.Validation
Node 22.23.3: all 21 focused tests pass. The SDK build, strict TypeScript check of the test file, formatting and
git diff --checkalso pass. The rest of the suite was not run because it depends on external services.cd JS/edgechains/arakoodev npm run build npm run test:palm2Demo
20-second test-output replay and transcript. The published asset hashes match the locally verified files.
This records the real local integration test. The second server supplies deterministic fixture responses; no Google API request was made. The example also supports an account-provided model and API key for live use, but Google authentication, current model availability and live generation remain unverified.
PALM2_DEMO=1 npm run test:palm2 -- -t 'runs the Jsonnet HTTP example'The sample API binds to localhost and has no public-deployment authentication. A model must be supplied by the caller or
GEMINI_MODEL; it no longer silently targets the hardcodedgemini-proendpoint.AI assistance: implementation, tests and an additional source review were prepared with OpenAI Codex.