Reduce DB query for every request

[jonathan-anyword]

Hi All,
I'm using flipper 1.2.
My config is:

require 'flipper'
require 'flipper/adapters/active_record'

Rails.application.config.to_prepare do
  adapter = case Rails.env
            when 'test'
              Flipper::Adapters::Memory.new
            else
              Flipper::Adapters::ActiveRecord.new(feature_class: FlipperFeature, gate_class: FlipperGate)
            end

  Flipper.configure do |config|
    config.adapter { adapter }
  end
end

In debug I see that every request have:

SELECT "flipper_features"."key" AS feature_key, "flipper_gates"."key", "flipper_gates"."value" FROM "flipper_features" LEFT OUTER JOIN "flipper_gates" ON "flipper_features"."key" = "flipper_gates"."feature_key"

First, I'm trying to understand what is this query?
Second, it looks like relatively static data, cant it be cached? (without full caching adapter)

Thanks for the help

[jonathan-anyword]

One option I had is this:

class CachedActiveRecordAdapter < Flipper::Adapters::ActiveRecord
  CACHE_KEY = 'flipper_features'

  def get_all
    Rails.cache.fetch(CACHE_KEY, expires_in: 1.hour) do
      super.as_json
    end
  end

  def set(feature, gate, thing, options = {})
    super(feature, gate, thing, options)
    Rails.cache.delete(CACHE_KEY)
  end

  def delete(feature, gate)
    super(feature, gate)
    Rails.cache.delete(CACHE_KEY)
  end

  def clear(feature)
    super(feature)
    Rails.cache.delete(CACHE_KEY)
  end
end

Rails.application.config.to_prepare do
  adapter = case Rails.env
            when 'test'
              Flipper::Adapters::Memory.new
            else
              CachedActiveRecordAdapter.new(feature_class: FlipperFeature, gate_class: FlipperGate)
            end

But it looks risky and not clean

[jnunemaker]

Check out the optimization docs.

https://www.flippercloud.io/docs/optimization

We have several cache adapters. I’d recommend in memory. I use that on many of my higher throughput apps.

For example, I have this on fireside:

FLIPPER_SHARED_CACHE = ActiveSupport::Cache::MemoryStore.new

Flipper.configure do |config|
  config.adapter do
    Flipper::Adapters::ActiveSupportCacheStore.new(
      Flipper::Adapters::ActiveRecord.new,
      FLIPPER_SHARED_CACHE,
      expires_in: 10.seconds
    )
  end
end

I see the shared cache outside the adapter block so it is shared across threads if using puma.

[jonathan-anyword]

Thanks
I even did 2 level cache

FLIPPER_SHARED_CACHE = ActiveSupport::Cache::RedisCacheStore.new
FLIPPER_LOCAL_CACHE = ActiveSupport::Cache::MemoryStore.new
db_adapter = Flipper::Adapters::ActiveRecord.new(feature_class: FlipperFeature, gate_class: FlipperGate)
Flipper::Adapters::ActiveSupportCacheStore.new(
  Flipper::Adapters::ActiveSupportCacheStore.new(
    db_adapter,
    FLIPPER_SHARED_CACHE,
    expires_in: 300.seconds
  ),
  FLIPPER_LOCAL_CACHE,
  expires_in: 30.seconds
)