Stub getCommitOid correctly and check calls

Author: mbg

src/git-utils.test.ts

@@ -34,6 +34,7 @@ test.serial(
       const actualRef = await gitUtils.getRef();
       t.deepEqual(actualRef, expectedRef);
 
+      t.is(callback.callCount, 1);
       t.true(callback.calledOnceWith(tmpDir, "HEAD"));
     });
   },
@@ -58,6 +59,8 @@ test.serial(
       const actualRef = await gitUtils.getRef();
       t.deepEqual(actualRef, expectedRef);
 
+      t.is(callback.callCount, 2);
+      t.true(callback.calledWith(tmpDir, "HEAD"));
       t.true(callback.calledWith(tmpDir, "refs/remotes/pull/1/merge"));
     });
   },
@@ -72,14 +75,18 @@ test.serial(
       process.env["GITHUB_SHA"] = "a".repeat(40);
 
       const callback = sinon.stub(gitUtils, "getCommitOid");
-      callback.withArgs(tmpDir, "refs/pull/1/merge").resolves("a".repeat(40));
+      callback
+        .withArgs(tmpDir, "refs/remotes/pull/1/merge")
+        .resolves("a".repeat(40));
       callback.withArgs(tmpDir, "HEAD").resolves("b".repeat(40));
+      callback.throws(new Error("Unexpected getCommitOid call in test."));
 
       const actualRef = await gitUtils.getRef();
       t.deepEqual(actualRef, "refs/pull/1/head");
 
-      t.true(callback.calledOnceWith(tmpDir, "refs/pull/1/merge"));
-      t.true(callback.calledOnceWith(tmpDir, "HEAD"));
+      t.is(callback.callCount, 2);
+      t.true(callback.calledWith(tmpDir, "refs/remotes/pull/1/merge"));
+      t.true(callback.calledWith(tmpDir, "HEAD"));
     });
   },
 );
@@ -107,8 +114,8 @@ test.serial(
       const actualRef = await gitUtils.getRef();
       t.deepEqual(actualRef, "refs/pull/2/merge");
 
-      t.true(callback.calledOnceWith(tmpDir, "refs/pull/1/merge"));
-      t.true(callback.calledOnceWith(tmpDir, "HEAD"));
+      // getCommitOid shouldn't be called, because the ref should be taken from the input
+      t.is(callback.callCount, 0);
     });
   },
 );