Skip to content

test: delete all kokoro references to Node 18 in kokoro tests - #3999

Merged
danieljbruce merged 8 commits into
mainfrom
remove-the-node-18-tests-from-ci
Sep 15, 2026
Merged

test: delete all kokoro references to Node 18 in kokoro tests#3999
danieljbruce merged 8 commits into
mainfrom
remove-the-node-18-tests-from-ci

Conversation

@danieljbruce

@danieljbruce danieljbruce commented Sep 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This pull request removes the configs so that no kokoro job pointing to node 18 exists and migrates all other configurations to node 22.

  • common configurations all now point to node 22
  • release config files all now point to node 22
  • the node 18 folder has been deleted

Impact

Removes unneeded test infrastructure and modernizes the configuration infrastructure.

Testing

This PR drops testing infrastructure as intended.

@product-auto-label product-auto-label Bot added the size: m Pull request size is medium. label Sep 3, 2026
@generated-files-bot

generated-files-bot Bot commented Sep 3, 2026 •
edited
Loading

Copy link
Copy Markdown

Warning: This pull request is touching the following templated files:

  • .kokoro/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node18/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node18/lint.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node18/samples-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node18/system-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node18/test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node18/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node18/samples-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node18/system-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node18/test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/release/docs-devsite.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/release/docs.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/release/docs.sh - .kokoro files are templated and should be updated in synthtool
  • .kokoro/test.bat - .kokoro files are templated and should be updated in synthtool
  • .kokoro/trampoline_v2.sh - .kokoro files are templated and should be updated in synthtool

@danieljbruce danieljbruce added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 3, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 3, 2026
@danieljbruce danieljbruce changed the title Delete all kokoro references to Node 18 test: delete all kokoro references to Node 18 in kokoro tests Sep 3, 2026
@danieljbruce danieljbruce added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 3, 2026
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 3, 2026
@product-auto-label product-auto-label Bot added size: u Pull request is empty. and removed size: m Pull request size is medium. labels Sep 3, 2026
@danieljbruce
danieljbruce marked this pull request as ready for review September 3, 2026 19:32
bshaffer
bshaffer reviewed Sep 3, 2026
View reviewed changes

@bshaffer bshaffer left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It says Files Changed: 0, is that intentional?

@danieljbruce

danieljbruce commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

It says Files Changed: 0, is that intentional?

Looks like the post-processor undid changes.

@danieljbruce danieljbruce added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 4, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 4, 2026
@danieljbruce danieljbruce added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 9, 2026
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 9, 2026
@feywind feywind added the owlbot:ignore instruct owl-bot to ignore a PR label Sep 10, 2026
@danieljbruce
danieljbruce requested a review from a team as a code owner September 15, 2026 15:26
@product-auto-label product-auto-label Bot added size: s Pull request size is small. and removed size: u Pull request is empty. labels Sep 15, 2026
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Sep 15, 2026
@danieljbruce

danieljbruce commented Sep 15, 2026

Copy link
Copy Markdown
Contributor Author

We'll need to do just one follow-up task so that the owlbot post-processor doesn't try to overwrite these changes in future PRs.

@danieljbruce
danieljbruce enabled auto-merge (squash) September 15, 2026 15:45
@danieljbruce
danieljbruce merged commit 386e8c8 into main Sep 15, 2026
28 checks passed
@danieljbruce
danieljbruce deleted the remove-the-node-18-tests-from-ci branch September 15, 2026 16:07
@danieljbruce danieljbruce mentioned this pull request Sep 15, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bshaffer bshaffer bshaffer left review comments
@quirogas quirogas quirogas approved these changes

Assignees

@bshaffer bshaffer

Labels

owlbot:ignore instruct owl-bot to ignore a PR size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@danieljbruce @bshaffer @quirogas @yoshi-kokoro @feywind