doubt about Class Critic

[wenjunyang]

i have a doubt about class Critic in applications/ChatGPT/chatgpt/nn/critic.py. in common A2C RL algorithm，Critic is the function of current state $s_i$，Critic should be independent with action $a_i$. but both in applications/ChatGPT/chatgpt/experience_maker/naive.py and applications/ChatGPT/chatgpt/trainer/ppo.py , action_mask are passed. that means Critic depend on $s_i$ and $a_i$, is it reasonable?

[wenjunyang]

pic source: here，page 57

[FrankLeeeee]

Hi @wenjunyang , this Development | Core category is used for feature discussion by developers. I will change this to Community | Q&A instead. Meanwhile, I have informed our developers in charge of the ChatGPT application and they would respond soon.

[ht-zhou]

Hello @wenjunyang , thanks for your feedback. I have consider about it. And find it is actually something wrong here.
We will fix it soon, thanks a lot.

[ht-zhou]

@wenjunyang We also invite you to fix it and submit a PR to our repo. Looking forward~

[wenjunyang]

ok, i will try