Repository navigation
[sysvabi64] 2026q3 review comments on TLS chapter - #435
Merged
Merged
Conversation
Typo fixes: * Removed duplicate "of accessing TLS". * Added apostrophes to executable's. * Expanded the local dynamic TLS section. The local dynamic section only mentioned that the _TLS_MODULE_BASE_ symbol was to be used to obtain the base of the TLS block for the module. It didn't mention the additional calculation to find the offset of the variable from _TLS_MODULE_BASE_. Added an example and the :dtprel_hi12: operator that was missing from the list of assembler operators.
|
LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typo fixes:
The local dynamic section only mentioned that the TLS_MODULE_BASE symbol was to be used to obtain the base of the TLS block for the module. It didn't mention the additional calculation to find the offset of the variable from TLS_MODULE_BASE. Added an example and the :dtprel_hi12: operator that was missing from the list of assembler operators.