Repository navigation
Modify interop ID for g24_rec709_scene - #181
Conversation
|
|
|
Thank you for the contribution @17tet. As per the contribution guidelines, all commits need to be signed to pass the DCO check, and we need a signed CLA to pass the CLA check. |
Rename the InteropId for the 'Gamma 2.4 Encoded Rec.709' colorspace from 'ocio:g24_rec709_scene' to 'g24_rec709_scene', now that it is an official CIF texture colorspace as of the 1.1 revision. Both identifiers are kept as aliases for backward compatibility. Fixes AcademySoftwareFoundation#178 Signed-off-by: 17tet <sirenhadis@gmail.com>
0c8df33 to
7bda2d9
Compare
It should be good to go now, thanks for the heads up! |
|
This needs to be done in the spreadsheet: https://docs.google.com/spreadsheets/d/1V6tbYwPOK8fssOpO91LTUMV_5Lj1ULjadz65r4zxBHw/edit?usp=sharing, then we can verify than pulling the CSV files is matching the suggested commit changes otherwise they will be lost next pull. |
|
I approve, but I am not a maintainer here... |
doug-walker
left a comment
doug-walker
left a comment
There was a problem hiding this comment.
@17tet, What you did in the .csv was correct, though as Thomas wrote, in the future you need to update the spreadsheet first and then pull down the .csv files from there. In this case, I updated the spreadsheet for you, since it's your first PR. Thanks for the contribution!
OK! Thank you for explaining the workflow and for taking the time to review the PR! |
5 participants
Fixes #178
Renames the InteropId for Gamma 2.4 Encoded Rec.709 from ocio:g24_rec709_scene to g24_rec709_scene, now that it's an official CIF texture colorspace (1.1 revision). Kept ocio:g24_rec709_scene as an alias so existing configs don't break.
Changed both the CG and Studio config mapping CSVs, the Reference config doesn't define this colorspace so nothing to do there.