Repository navigation
Conversation
The same value was computed three times. Time constructing processors for all displays/views/spaces in the ACES studio config goes from 279ms to 223ms on Apple M3 Max. Signed-off-by: Brecht Van Lommel <brecht@blender.org>
Contributor
|
Interesting wonder why the optimiser didn't hoist the function call. LGTM |
KevinJW
approved these changes
Oct 1, 2026
Contributor
Author
|
It would need to be a pure function without side effects for that, the compiler can't assume that for |
Contributor
|
Indeed, I just expanded the diff in the PR and noticed that and was about to go down the std::function standardese :-) |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The same value was computed three times.
Time constructing processors for all displays/views/spaces in the ACES studio config goes from 279ms to 223ms on Apple M3 Max.