Repository navigation
Conversation
Signed-off-by: Cameron Kerr <camkerr@gmail.com>
Signed-off-by: Cameron Kerr <camkerr@gmail.com>
camkerr
force-pushed
the
color-abgr-fixes
branch
from
October 3, 2026 01:50
f2acce8 to
b313a7a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2070 +/- ##
==========================================
+ Coverage 83.56% 83.58% +0.01%
==========================================
Files 182 182
Lines 13554 13570 +16
Branches 1260 1260
==========================================
+ Hits 11326 11342 +16
Misses 2055 2055
Partials 173 173
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
…int" Signed-off-by: Cameron Kerr <camkerr@gmail.com>
Contributor
Author
|
I also went ahead and renamed the If we're renaming functions, might as well tidy this up. Doesn't make sense to have one be "int" and the other "integer". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2069
Summarize your change.
I renamed two
Colorfunctions to match the more common ABGR pattern:from_agbr_int>from_abgr_intto_agbr_integer>to_abgr_intNot sure if this was a typo with the original implementation, or if this was intentional. Happy to discuss.
I also corrected the newly renamed
from_abgr_intso that the order of the channels is correct. It was swapping the blue and green channels.Reference associated tests.
I updated a few tests in
test_color.py:otio.core.Color.ORANGEtotest_convert_to. Orange is the only colour in our predefined list where the red, green and blue channel values are unique, so good to have in there.test_from_abgr_intto use the "abgr" naming but also correctly convert 4281740498 to #d22c36ff.test_to_abgr_intwhich was only tested previously using Black & White up intest_convert_totest_abgr_round_tripwhich tests an int > hex > int round trip. Previously this would've failed due to the blue and green channel swapping.LLM Use: Claude identified this problem. Code written by me.