Repository navigation
Upgrade Duende IdentityServer to 8.0.9 - #563
Merged
Merged
Conversation
- Bump Duende.IdentityServer from 7.4.5 to 8.0.9 in IdentityServer.ServerSample - Pass HttpContext.RequestAborted to IIdentityServerInteractionService.GetLogoutContextAsync in AccountController, as v8 requires a CancellationToken on async interface methods No other breaking changes from the v8 upgrade guide affect the sample.
There was a problem hiding this comment.
🟢 Approval recommended
The package is compatible with the sample’s target framework, and the required API migration is correctly implemented.
0 open findings
What changed in this PR
Upgrades the IdentityServer sample to Duende IdentityServer 8.0.9 and adapts logout handling to its cancellation-token API.
Changes:
- Updated the Duende IdentityServer dependency.
- Propagated request cancellation during logout-context retrieval.
| File | Description |
|---|---|
IdentityServer.ServerSample.csproj |
Upgrades Duende IdentityServer to 8.0.9. |
AccountController.cs |
Passes RequestAborted to the logout API. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade Duende IdentityServer to v8.0.9
Summary
Upgrades
Duende.IdentityServerin theIdentityServer.ServerSampleproject from 7.4.5 to 8.0.9. I went through the v8 upgrade guide step by step and checked each item against the codebase.Changes
IdentityServer.ServerSample.csproj: bumpedDuende.IdentityServerfrom7.4.5to8.0.9.AccountController.cs:GetLogoutContextAsyncnow receivesHttpContext.RequestAborted. v8 requires aCancellationTokenon all async store and service interface methods.Upgrade guide review
No other changes were needed. The sample only uses
IIdentityServerInteractionService(GetLogoutContextAsync,IsValidReturnUrl), in-memory clients and identity resources, and a developer signing credential. Searches of the code and settings found none of the affected APIs or features, including:IClientStoreandIResourceStoreinterfacesICache<T>/IClock/ICancellationTokenProviderITokenValidatorandIRefreshTokenServiceIUserSession,IProfileService,AuthorizationError, DPoP andJwtBearerIAuthorizationParametersMessageStore, licensing types,options.Previewand SAMLBehavioral notes
Verification
IdentityServer.ServerSamplebuilds successfully against 8.0.9.Testing suggestions