Repository navigation
Upgrade NuGet dependencies (Azure SDK, Microsoft.* 10.0.12, AngleSharp) - #564
Merged
Merged
Conversation
added 3 commits
October 9, 2026 15:00
- Bump Azure.Identity in ActiveLogin.Authentication.BankId.AzureKeyVault - Bump Microsoft.Extensions.Hosting.Abstractions from 10.0.2 to 10.0.3 in Phone.ConsoleSample to resolve NU1605 package downgrade, as Azure.Core 1.53.0 (pulled in by Azure.Identity 1.21.0) requires >= 10.0.3
- Bump Azure.Security.KeyVault.Secrets in ActiveLogin.Authentication.BankId.AzureKeyVault - Default Key Vault service version is now 2025-07-01 (was 7.6) - No code changes required
- Microsoft.AspNetCore.Authentication.OpenIdConnect 10.0.2 -> 10.0.12 - Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation 10.0.2 -> 10.0.12 - Microsoft.AspNetCore.Mvc.Testing 10.0.2 -> 10.0.12 - Microsoft.AspNetCore.TestHost 10.0.2 -> 10.0.12 - Microsoft.Extensions.Configuration.UserSecrets 10.0.2 -> 10.0.12 - Microsoft.Extensions.Hosting 10.0.2 -> 10.0.12 - Microsoft.Extensions.Hosting.Abstractions 10.0.3 -> 10.0.12 - Microsoft.Extensions.Http 10.0.2 -> 10.0.12 - Microsoft.Extensions.Logging.Abstractions 10.0.2 -> 10.0.12 - System.Text.Json 10.0.2 -> 10.0.12 - AngleSharp 1.8.3 -> 1.8.4 Related packages were bumped together to avoid NU1605 package downgrade errors. Application Insights packages were intentionally left unchanged.
There was a problem hiding this comment.
🔵 Needs a closer look
Authentication and live Key Vault behavior changed through dependency upgrades without unit or environment testing.
0 open findings
What changed in this PR
Updates Azure SDK, .NET 10 servicing, and AngleSharp dependencies while retaining existing Application Insights versions.
Changes:
- Upgrades Azure Identity and Key Vault packages.
- Aligns Microsoft/System packages to 10.0.12.
- Updates AngleSharp and related ASP.NET Core test dependencies.
| File | Description |
|---|---|
test/ActiveLogin.Authentication.BankId.AspNetCore.Test/ActiveLogin.Authentication.BankId.AspNetCore.Test.csproj |
Updates AngleSharp and ASP.NET Core test packages. |
src/ActiveLogin.Authentication.BankId.Core/ActiveLogin.Authentication.BankId.Core.csproj |
Updates HTTP and logging abstractions. |
src/ActiveLogin.Authentication.BankId.AzureKeyVault/ActiveLogin.Authentication.BankId.AzureKeyVault.csproj |
Upgrades Azure Identity and Key Vault SDKs. |
src/ActiveLogin.Authentication.BankId.Api/ActiveLogin.Authentication.BankId.Api.csproj |
Updates System.Text.Json. |
samples/Phone.ConsoleSample/Phone.ConsoleSample.csproj |
Aligns hosting and configuration dependencies. |
samples/IdentityServer.ServerSample/IdentityServer.ServerSample.csproj |
Updates Razor runtime compilation. |
samples/IdentityServer.ClientSample/IdentityServer.ClientSample.csproj |
Updates OpenID Connect authentication. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades NuGet dependencies across the solution:
Application Insights packages are intentionally left unchanged.
Changes
Azure SDK (
ActiveLogin.Authentication.BankId.AzureKeyVault)Azure.IdentityAzure.Security.KeyVault.SecretsMicrosoft / System packages
Microsoft.AspNetCore.Authentication.OpenIdConnectMicrosoft.AspNetCore.Mvc.Razor.RuntimeCompilationMicrosoft.AspNetCore.Mvc.TestingMicrosoft.AspNetCore.TestHostMicrosoft.Extensions.Configuration.UserSecretsMicrosoft.Extensions.HostingMicrosoft.Extensions.Hosting.AbstractionsMicrosoft.Extensions.HttpMicrosoft.Extensions.Logging.AbstractionsSystem.Text.JsonOther
AngleSharpNotes
Microsoft.Extensions.Hosting.Abstractions10.0.3 or later inPhone.ConsoleSample.Mvc.TestingrequiresTestHost.HostingrequiresHosting.Abstractions.Extensions.HttprequiresLogging.Abstractions.Azure.Security.KeyVault.Secretsnow defaults to service version2025-07-01(was7.6).Testing