Skip to content

Upgrade NuGet dependencies (Azure SDK, Microsoft.* 10.0.12, AngleSharp) - #564

Merged
elinohlsson merged 3 commits into
mainfrom
feature/upgrade-azure-identity
Oct 9, 2026
Merged

elinohlsson merged 3 commits into
mainfrom
feature/upgrade-azure-identity

Conversation

@elinohlsson

@elinohlsson elinohlsson commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Upgrades NuGet dependencies across the solution:

  • Azure SDK packages
  • Microsoft.* and System.* packages (to 10.0.12)
  • AngleSharp

Application Insights packages are intentionally left unchanged.

Changes

Azure SDK (ActiveLogin.Authentication.BankId.AzureKeyVault)

Package From To
Azure.Identity 1.17.1 1.21.0
Azure.Security.KeyVault.Secrets 4.8.0 4.11.2

Microsoft / System packages

Package From To
Microsoft.AspNetCore.Authentication.OpenIdConnect 10.0.2 10.0.12
Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation 10.0.2 10.0.12
Microsoft.AspNetCore.Mvc.Testing 10.0.2 10.0.12
Microsoft.AspNetCore.TestHost 10.0.2 10.0.12
Microsoft.Extensions.Configuration.UserSecrets 10.0.2 10.0.12
Microsoft.Extensions.Hosting 10.0.2 10.0.12
Microsoft.Extensions.Hosting.Abstractions 10.0.2 10.0.12
Microsoft.Extensions.Http 10.0.2 10.0.12
Microsoft.Extensions.Logging.Abstractions 10.0.2 10.0.12
System.Text.Json 10.0.2 10.0.12

Other

Package From To
AngleSharp 1.8.3 1.8.4

Notes

  • Package downgrade errors (NU1605): Several packages were bumped together to resolve these errors:
    • Azure.Identity 1.21.0 (via Azure.Core) requires Microsoft.Extensions.Hosting.Abstractions 10.0.3 or later in Phone.ConsoleSample.
    • Mvc.Testing requires TestHost.
    • Hosting requires Hosting.Abstractions.
    • Extensions.Http requires Logging.Abstractions.
  • Breaking changes: The release notes for Azure.Identity and Azure.Security.KeyVault.Secrets show none that affect this code. The 1.20.0 breaking change applies to APIs that aren't used here. No code changes were required.
  • Key Vault service version: Azure.Security.KeyVault.Secrets now defaults to service version 2025-07-01 (was 7.6).

Testing

  • Full solution builds successfully
  • Unit tests (not run as part of this change)
  • Manual verification of Key Vault authentication and secret access in a real environment

Elin Fokine added 3 commits October 9, 2026 15:00
- Bump Azure.Identity in ActiveLogin.Authentication.BankId.AzureKeyVault
- Bump Microsoft.Extensions.Hosting.Abstractions from 10.0.2 to 10.0.3 in
  Phone.ConsoleSample to resolve NU1605 package downgrade, as Azure.Core
  1.53.0 (pulled in by Azure.Identity 1.21.0) requires >= 10.0.3
- Bump Azure.Security.KeyVault.Secrets in
  ActiveLogin.Authentication.BankId.AzureKeyVault
- Default Key Vault service version is now 2025-07-01 (was 7.6)
- No code changes required
- Microsoft.AspNetCore.Authentication.OpenIdConnect 10.0.2 -> 10.0.12
- Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation 10.0.2 -> 10.0.12
- Microsoft.AspNetCore.Mvc.Testing 10.0.2 -> 10.0.12
- Microsoft.AspNetCore.TestHost 10.0.2 -> 10.0.12
- Microsoft.Extensions.Configuration.UserSecrets 10.0.2 -> 10.0.12
- Microsoft.Extensions.Hosting 10.0.2 -> 10.0.12
- Microsoft.Extensions.Hosting.Abstractions 10.0.3 -> 10.0.12
- Microsoft.Extensions.Http 10.0.2 -> 10.0.12
- Microsoft.Extensions.Logging.Abstractions 10.0.2 -> 10.0.12
- System.Text.Json 10.0.2 -> 10.0.12
- AngleSharp 1.8.3 -> 1.8.4

Related packages were bumped together to avoid NU1605 package downgrade
errors. Application Insights packages were intentionally left unchanged.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Authentication and live Key Vault behavior changed through dependency upgrades without unit or environment testing.

0 open findings

What changed in this PR

Updates Azure SDK, .NET 10 servicing, and AngleSharp dependencies while retaining existing Application Insights versions.

Changes:

  • Upgrades Azure Identity and Key Vault packages.
  • Aligns Microsoft/System packages to 10.0.12.
  • Updates AngleSharp and related ASP.NET Core test dependencies.
File Description
test/​ActiveLogin.Authentication.BankId.AspNetCore.Test/​ActiveLogin.Authentication.BankId.AspNetCore.Test.csproj Updates AngleSharp and ASP.NET Core test packages.
src/​ActiveLogin.Authentication.BankId.Core/​ActiveLogin.Authentication.BankId.Core.csproj Updates HTTP and logging abstractions.
src/​ActiveLogin.Authentication.BankId.AzureKeyVault/​ActiveLogin.Authentication.BankId.AzureKeyVault.csproj Upgrades Azure Identity and Key Vault SDKs.
src/​ActiveLogin.Authentication.BankId.Api/​ActiveLogin.Authentication.BankId.Api.csproj Updates System.Text.Json.
samples/​Phone.ConsoleSample/​Phone.ConsoleSample.csproj Aligns hosting and configuration dependencies.
samples/​IdentityServer.ServerSample/​IdentityServer.ServerSample.csproj Updates Razor runtime compilation.
samples/​IdentityServer.ClientSample/​IdentityServer.ClientSample.csproj Updates OpenID Connect authentication.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The package versions are valid, internally aligned, and CI executes the solution test suite for pull requests.

0 open findings

🧠 Review effort: Balanced

@elinohlsson
elinohlsson merged commit df56440 into main Oct 9, 2026
18 checks passed
@elinohlsson
elinohlsson deleted the feature/upgrade-azure-identity branch October 9, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants