Skip to content

Performance issues? #695

Open
Open

Description

@Obiwarn

This is a minor issue but when I do a reactive search in my table, Griddle felt a lot snappier than this table (I guess it could have to do with column resizing?). Maybe there is room for performance improvements (e.g. fixed widths or sth.)?

Activity

  1. Obiwarn commented on Sep 9, 2016

    @Obiwarn
    Author

    Um. Just wanted to let you know this issue gets quite massive when you have a decent table. e.g. mine has like 10 columns with 3 dates and when I want to show more than 10 rows it gets quite laggy.

  2. AllenFang commented on Sep 11, 2016

    @AllenFang
    Owner

    @Obiwarn, yap, there's actually a known performance issue. I'll try to fix it. But really need some time.. Sorry, I'm also busy on my work. So PR is welcome.

  3. zekedroid commented on Sep 13, 2016

    @zekedroid

    By fixing it, are you talking about implementing virtual rendering? Because that would be awesome in many levels. It's the last thing this needs to totally overshadow other static table libraries.

  4. Obiwarn commented on Sep 14, 2016

    @Obiwarn
    Author

    @AllenFang indeed. I reviewed all popular table libs and yours is just fantastic and has such great code samples.

  5. AllenFang commented on Sep 16, 2016

    @AllenFang
    Owner

    @Obiwarn, thanks, I'll do my best. BTW, #566 tried to fix the rendering performance issue and I still consider if add this PR to v3.0.0. Anyway, there're a lots of jobs to do in v3.0.0, so PR is welcome :)

  6. oakley808 commented on Sep 30, 2016

    @oakley808

    I'd have to agree with others here. This is by far the best table component I've used. 👏
    I ditched fixed-data-table and griddle for react-bootstrap-table. But the performance on 750 rows X 25 columns is about 10s to render. [ouch] But I can use pagination to mitigate it for now. :-)

  7. oeph commented on Oct 20, 2016

    @oeph

    @AllenFang i implemented lazy loading (#26, #557) for this table, which should fix the performance issue. I can provide a PR, but this will take some time since i have a lot to do at work.

  8. AllenFang commented on Oct 23, 2016

    @AllenFang
    Owner

    @oeph, that's ok, PR is welcome :)

  9. kzbikowski commented on Jan 26, 2017

    @kzbikowski

    @oeph any progress in terms of lazy loading? I'm thinking of implementing it but don't want to duplicate the work

  10. oeph commented on Feb 5, 2017

    @oeph

    @kzbikowski i have it done. i will merge on current branch and make a PR. not sure tho on the exact time

  11. SimonDKnight commented on Mar 9, 2017

    @SimonDKnight

    Hi @oeph , did your implementation of infinite scroll get merged in? I am super keen to get infinite scroll working on the table. Thanks. Simon

  12. oeph commented on Apr 4, 2017

    @oeph

    since the lazy loading was implemented last year nov. there are major changes within the component itself. I'm working on the solution in the current version without breaking the current API, but for now i would suggest to use the method described in #1133 or use react-virtualized for example.

    since i'm busy at work i can't make any promises when i will have this finished

  13. nakulthebuilder commented on Oct 23, 2017

    @nakulthebuilder

    Hi just wanted to ask if lazy loading/virtualization is still being actively worked on? If not, in the above comment it @oeph mentions using this library with react-virtualized. Wondering if anyone could provide a simple example of how that would work. Thanks for this great library!

  14. JohnVLinton commented on May 1, 2018

    @JohnVLinton

    I'm having a lot of issues too with table load time. I have basically two tables on screen, one hidden, then when a user hits a tab, that table is then displayed. I'd be happy to do something more like div display:block vs. none to quickly show/hide it but doesn't seem obvious how I do this in React, so each tab toggle requires a real-time redraw...

  15. oeph commented on May 30, 2018

    @oeph

    @JohnVLinton To me that sounds more like a problem with the tab component. It could just render the selected tab instead of rendering both and using display:none;

    Since react-bootstrap-table is not actively worked on anymore, you should maybe look at https://github.com/react-bootstrap-table/react-bootstrap-table2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions