Skip to content

Hint popover close and folder buttons - #524

Merged
Eli Pinkerton (wallstop) merged 2 commits into
mainfrom
popover-close-hints
Nov 3, 2026
Merged

Eli Pinkerton (wallstop) merged 2 commits into
mainfrom
popover-close-hints

Conversation

@wallstop

@wallstop Eli Pinkerton (wallstop) commented Nov 3, 2026 •

Copy link
Copy Markdown
Collaborator

DISCLOSURE: LLM-GENERATED TEXT

Why: The popover close buttons and the Settings data folder Select button were the last commands without a hover hint.

What:

  • Hint every popover close button
  • Name the Settings data folder Select command on hover
  • Cover all six popovers and the settings data folder row

Refs #312

Why: the popover close (X) buttons and the Settings data-folder Select button
were the last commands without a hover hint. A glyph button or a dialog-short
label did not explain its purpose, and the close shortcut was invisible.

What: one shared close-button builder with a live hint replaces six inline
copies, and the Select button names the folder command.

Validation: the new PopoverFocusTests cases fail on the previous source with
empty hints and pass on the fix. Full EditMode suite 975/975 and check:gate
16/16 pass on Unity 6000.6.7f1 Windows. PlayMode discovery returned zero cases
on this host, so that suite was not exercised.

Refs #312
@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Walkthrough

Popover close buttons now show a tooltip with the current cancel key. The Settings data-folder Select button has a tooltip describing its action. Editor tests check the hints across popovers and with a remapped cancel key.

Changes: Popover tooltip hints

Layer / File(s) Summary
Add and validate popover tooltips
Editor/DataVisualizer/DataVisualizer.cs, Tests/Editor/PopoverFocusTests.cs, CHANGELOG.md
A shared helper adds a dynamic cancel-key tooltip to close buttons across six popover types. The Settings folder Select button has an action tooltip. Editor tests check these hints and verify that the close-button tooltip reflects a remapped key.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related issues

Possibly related PRs

Merge Risk: Minimal · up to 15b40

The hints no longer advertise a misleading cancel key. No merge-blocking issue remains identified.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: adding hints to popover close buttons and the folder button.
Description check Passed The description clearly states why the change exists and lists the three main changes. It omits the template's Type of Change and Checklist sections, but the core description is complete.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 7 functions across 2 files. (1 skipped: 1 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

ast-grep (0.51.1)

ast-grep could not parse rule config: /ast-grep-rules/ast-grep-essentials/rules/javascript/security/variable-sql-statement-injection.yml

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.
Recent review details
Context from checks skipped due to timeout: 1
  • GitHub Check: CodeRabbit
Additional context used
Code guidelines: 1
.llm/context.md — auto-discovered
Path-based instructions: 2
Applicability reference: AGENTS.md: # Repository Guidelines See the [AI Agent Guidelines](./.llm/context.md) for all AI agent guidelines.

CodeRabbit inference engine (.llm/context.md)

Files:

  • Tests/Editor/PopoverFocusTests.cs
  • Editor/DataVisualizer/DataVisualizer.cs
Applicability reference: AGENTS.md: # Repository Guidelines See the [AI Agent Guidelines](./.llm/context.md) for all AI agent guidelines.

CodeRabbit inference engine (.llm/context.md)

Files:

  • CHANGELOG.md
Learnings: 2
Common learnings
Learnt from: CR
Repo: Ambiguous-Interactive/DxVisualizer PR: 0
File: .llm/context.md:0-0
Timestamp: 2026-10-31T05:33:39.058Z
Learning: Applies to **/*.cs : Applicability reference:
AGENTS.md: # Repository Guidelines
See the [AI Agent Guidelines](./.llm/context.md) for all AI agent guidelines.

Source excerpt:
# LLM Agent Instructions

## Critical Rules

### C# and Unity

28. Name every C# method in PascalCase without underscores, including test methods. The C# source lint enforces this convention independently of IDE diagnostics.
Learnt from: CR
Repo: Ambiguous-Interactive/DxVisualizer PR: 0
File: .llm/context.md:0-0
Timestamp: 2026-10-31T05:33:39.058Z
Learning: Applicability reference:
AGENTS.md: # Repository Guidelines
See the [AI Agent Guidelines](./.llm/context.md) for all AI agent guidelines.

Source excerpt:
# LLM Agent Instructions

## Critical Rules

### C# and Unity

2. Format every modified `.cs` file with CSharpier 1.1.2 (print width 180 in `.csharpierrc`; `dotnet tool run csharpier -- format <paths>`) and every modified `.md` file with
   Prettier (print width 180 in `.prettierrc.json`; `npm run format:md`); treat both as gates. Generated and skill Markdown is exempt (`.prettierignore`), and table cells align to
   their widest cell, so table lines may exceed the width.
Learnt from: CR
Repo: Ambiguous-Interactive/DxVisualizer PR: 0
File: .llm/context.md:0-0
Timestamp: 2026-11-02T20:14:27.735Z
Learning: Applies to **/*.cs : Applicability reference:
AGENTS.md: # Repository Guidelines
See the [AI Agent Guidelines](./.llm/context.md) for all AI agent guidelines.

Source excerpt:
# LLM Agent Instructions

## Critical Rules

### C# and Unity

2. Format every modified `.cs` file with CSharpier 1.1.2 (print width 180 in `.csharpierrc`; `dotnet tool run csharpier -- format <paths>`) and every modified `.md` file with
   Prettier (print width 180 in `.prettierrc.json`; `npm run format:md`); treat both as gates. Generated and skill Markdown is exempt (`.prettierignore`), and table cells align to
   their widest cell, so table lines may exceed the width.
Learnt from: CR
Repo: Ambiguous-Interactive/DxVisualizer PR: 0
File: .llm/context.md:0-0
Timestamp: 2026-11-01T05:48:38.269Z
Learning: Applies to **/*.cs : Applicability reference:
AGENTS.md: # Repository Guidelines
See the [AI Agent Guidelines](./.llm/context.md) for all AI agent guidelines.

Source excerpt:
# LLM Agent Instructions

## Critical Rules

### C# and Unity

3. Resolve analyzer warnings before review.
Learning: 2026-10-31T05:33:39.058Z
Learnt from: CR
Repo: Ambiguous-Interactive/DxVisualizer PR: 0
File: .llm/context.md:0-0
Timestamp: 2026-10-31T05:33:39.058Z
Learning: Applies to **/*.cs : Applicability reference:
AGENTS.md: # Repository Guidelines
See the [AI Agent Guidelines](./.llm/context.md) for all AI agent guidelines.

Source excerpt:
# LLM Agent Instructions

## Critical Rules

### C# and Unity

29. Use `//` for standalone single-line comments and tool control directives only. Write ordinary multi-line explanations as one indented `/* ... */` block. Keep `///` XML
    documentation line-oriented. The C# source lint enforces this rule.

Applied to files:

  • Editor/DataVisualizer/DataVisualizer.cs

@coderabbitai coderabbitai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Fix comments: Fix CodeRabbit comments on this PR

Comment thread Editor/DataVisualizer/DataVisualizer.cs Resolved
Comment thread Editor/DataVisualizer/DataVisualizer.cs Resolved
Why: review found that the advertised cancel binding has a wider effect than
the X button: the binding also dismisses the parent type finder while the
nested confirmation is open, and a printable remap types into the Create and
Rename fields instead of closing. A static Close hint is accurate in every
context and keeps the helper free of duplicate event logic.

Validation: PopoverFocusTests 11/11 on Unity 6000.6.7f1 Windows; check:gate
16/16.

Refs #312, #524
@wallstop
Eli Pinkerton (wallstop) merged commit 5e83cdc into main Nov 3, 2026
3 checks passed
@wallstop
Eli Pinkerton (wallstop) deleted the popover-close-hints branch November 3, 2026 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant