Repository navigation
Hint popover close and folder buttons - #524
Conversation
Why: the popover close (X) buttons and the Settings data-folder Select button were the last commands without a hover hint. A glyph button or a dialog-short label did not explain its purpose, and the close shortcut was invisible. What: one shared close-button builder with a live hint replaces six inline copies, and the Select button names the folder command. Validation: the new PopoverFocusTests cases fail on the previous source with empty hints and pass on the fix. Full EditMode suite 975/975 and check:gate 16/16 pass on Unity 6000.6.7f1 Windows. PlayMode discovery returned zero cases on this host, so that suite was not exercised. Refs #312
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Why: review found that the advertised cancel binding has a wider effect than the X button: the binding also dismisses the parent type finder while the nested confirmation is open, and a printable remap types into the Create and Rename fields instead of closing. A static Close hint is accurate in every context and keeps the helper free of duplicate event logic. Validation: PopoverFocusTests 11/11 on Unity 6000.6.7f1 Windows; check:gate 16/16. Refs #312, #524
DISCLOSURE: LLM-GENERATED TEXT
Why: The popover close buttons and the Settings data folder Select button were the last commands without a hover hint.
What:
Refs #312