Skip to content

Keep long inspector labels readable - #528

Merged
Eli Pinkerton (wallstop) merged 2 commits into
mainfrom
inspector-label-pill-elision
Nov 3, 2026
Merged

Eli Pinkerton (wallstop) merged 2 commits into
mainfrom
inspector-label-pill-elision

Conversation

@wallstop

Copy link
Copy Markdown
Collaborator

DISCLOSURE: LLM-GENERATED TEXT

Why: A long asset label was cut off inside the fixed-height inspector pill and had no hover hint, so the full label was unreadable.

What:

  • End long label pills with an ellipsis
  • Show the full label on hover
  • Keep the remove button inside the pill

Refs #312

Why: a long asset label was cut off inside the fixed-height inspector pill, and
the text label had no hover hint, so the full label was unreadable.

What:
- Keep pill text on one line and end it with an ellipsis.
- Expose the full label text as a hover hint.
- Hold the remove button at its own width beside the clipped text.

Validation: new hosted regression fails on 10a5472 with an empty hint;
InspectorLabelPillsViewTests 3/3, LabelFilter 40/40, ObjectRowLayout 2/2,
ResponsivePaneLayout 9/9, PopoverFocus 11/11; check:gate 16/16.

Refs #312
@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Walkthrough

Inspector label pills now truncate long labels with an ellipsis and show the full label in a tooltip. The change also adds an editor test and updates the changelog and label editing documentation.

Changes: Inspector label pill display

Layer / File(s) Summary
Label pill display and validation
Editor/DataVisualizer/Styles/DataVisualizerStyles.uss, Editor/DataVisualizer/UI/InspectorLabelPillsView.cs, Tests/Editor/InspectorLabelPillsViewTests.cs, docs/search-and-filter.md, CHANGELOG.md
Label text stays on one line and uses an ellipsis when it exceeds the pill width. The remove button keeps its intrinsic width, and the label text tooltip shows the full label. The test checks the layout and tooltip. The documentation and changelog describe the behavior.

Estimated code review effort: 2 (Simple) | ~8 minutes

Possibly related issues

  • Issue 312 — The PR identifies this issue as addressed. Its description includes hover hints for clipped or ambiguous labels, which relates to the full-label tooltip added here.

Possibly related PRs

Merge Risk: Minimal · up to a9b4a

Long labels now remain readable through ellipsis and hover tooltips, with no concrete merge-blocking risk identified.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: improving readability for long inspector labels.
Description check Passed The description explains the problem and lists the three main changes. It references issue #312. It omits the Type of Change and Checklist sections from the template, but the core description is compl…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the problem and lists the three main changes. It references issue #312. It omits the Type of Change and Checklist sections from the template, but the core description is complete.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 2 functions across 3 files.

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Usage-based review receipt

  • Mode: Continue automatically
  • Reviewed files: 2
  • Waived: $0.50 (charged $0.00)
  • View usage details

Note

This review exceeded your plan’s limits and used usage-based reviews—free during trial, billed after paid activation unless disabled. Manage usage-based reviews.

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.
Recent review details
Context from checks skipped due to timeout: 1
  • GitHub Check: CodeRabbit
Additional context used
Code guidelines: 1
.llm/context.md — auto-discovered
Path-based instructions: 1
Applicability reference: AGENTS.md: # Repository Guidelines See the [AI Agent Guidelines](./.llm/context.md) for all AI agent guidelines.

CodeRabbit inference engine (.llm/context.md)

Files:

  • Editor/DataVisualizer/DataVisualizer.cs
  • Tests/Editor/InspectorLabelPillsViewTests.cs
Learnings: 2
Common learnings
Learnt from: CR
Repo: Ambiguous-Interactive/DxVisualizer PR: 0
File: .llm/context.md:0-0
Timestamp: 2026-10-31T05:33:39.058Z
Learning: Applicability reference:
AGENTS.md: # Repository Guidelines
See the [AI Agent Guidelines](./.llm/context.md) for all AI agent guidelines.

Source excerpt:
# LLM Agent Instructions

## Critical Rules

### C# and Unity

2. Format every modified `.cs` file with CSharpier 1.1.2 (print width 180 in `.csharpierrc`; `dotnet tool run csharpier -- format <paths>`) and every modified `.md` file with
   Prettier (print width 180 in `.prettierrc.json`; `npm run format:md`); treat both as gates. Generated and skill Markdown is exempt (`.prettierignore`), and table cells align to
   their widest cell, so table lines may exceed the width.
Learnt from: CR
Repo: Ambiguous-Interactive/DxVisualizer PR: 0
File: .llm/context.md:0-0
Timestamp: 2026-11-02T20:14:27.735Z
Learning: Applies to **/*.cs : Applicability reference:
AGENTS.md: # Repository Guidelines
See the [AI Agent Guidelines](./.llm/context.md) for all AI agent guidelines.

Source excerpt:
# LLM Agent Instructions

## Critical Rules

### C# and Unity

2. Format every modified `.cs` file with CSharpier 1.1.2 (print width 180 in `.csharpierrc`; `dotnet tool run csharpier -- format <paths>`) and every modified `.md` file with
   Prettier (print width 180 in `.prettierrc.json`; `npm run format:md`); treat both as gates. Generated and skill Markdown is exempt (`.prettierignore`), and table cells align to
   their widest cell, so table lines may exceed the width.
Learning: 2026-10-31T05:33:39.058Z
Learnt from: CR
Repo: Ambiguous-Interactive/DxVisualizer PR: 0
File: .llm/context.md:0-0
Timestamp: 2026-10-31T05:33:39.058Z
Learning: Applies to **/*.cs : Applicability reference:
AGENTS.md: # Repository Guidelines
See the [AI Agent Guidelines](./.llm/context.md) for all AI agent guidelines.

Source excerpt:
# LLM Agent Instructions

## Critical Rules

### C# and Unity

29. Use `//` for standalone single-line comments and tool control directives only. Write ordinary multi-line explanations as one indented `/* ... */` block. Keep `///` XML
    documentation line-oriented. The C# source lint enforces this rule.

Applied to files:

  • Editor/DataVisualizer/DataVisualizer.cs
Additional comments: 2
Editor/DataVisualizer/DataVisualizer.cs: 1

7756-7760: LGTM!

Tests/Editor/InspectorLabelPillsViewTests.cs: 1

7-7: LGTM!

Also applies to: 92-122

@coderabbitai coderabbitai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Fix comments: Fix CodeRabbit comments on this PR

Why: review found that the same paperclip-length labels on the filter pills
still had no hint, so a clipped active label was unreadable.

What:
- Carry the full label on the AND/OR pill container.
- Assert the rendered label reports elision.

Validation: LabelFilter 40/40, InspectorLabelPillsViewTests 3/3;
check:gate 16/16.

Refs #312
@wallstop
Eli Pinkerton (wallstop) merged commit 1e63efc into main Nov 3, 2026
5 checks passed
@wallstop
Eli Pinkerton (wallstop) deleted the inspector-label-pill-elision branch November 3, 2026 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant