Repository navigation
Conversation
`unsigned_int` decoding reads at most five bytes and keeps the low 32 bits, the same as `fc::raw::unpack` in Spring. Adds `unsigned_int_decode_test`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unsigned_intdecoding now reads at most five bytes and keeps the low 32 bits, the same asfc::raw::unpackin Spring (libraries/libfc/include/fc/io/raw.hpp); the loop condition is now identical to fc's. Encodings written byoperator<<, cleos and the SDKs decode as before.unsigned_int_decode_test(tests/unit/varint_tests.cpp) covers the shortest encoding at every width, longer encodings up to five bytes, the five-byte limit, discarded high bits and truncated input.Contracts rebuilt with this change get new WASM; their ABIs do not change.