Repository navigation
Improve linter warnings - #143
Merged
Merged
Conversation
Member
Author
|
Seems to work: https://github.com/TheAssassin/test-broken-appimages/actions/runs/41346919329 Needs some refactoring, though, this was too verbose before and still is. GitHub seems to render everything just fine, though. Should be fine. |
A varargs based logging system that auto-detects GitHub actions environments and turns warnings and errors into annotations that are rendered nicely both in the job log and on the overview page of the workflow. Designed to replace all other logging in the long run. So far, only die() uses the new setup, i.e., it now supports format strings. The rest of the code needs to be reviewed and changes should follow in increments to keep commits to a reasonable size.
Probably legacy code. We have this infrastructure and should use it. Yes, it's technically the same, but less duplication overall.
This allows compilers, IDEs, editors, etc. to render the format strings accordingly and provide better user feedback.
Basically any message that printed ERROR:, WARNING:, etc.
This won't leak during execution as the program terminates anyway, but it's still cleaner.
No need to print these twice: the warnings will render nicely already.
TheAssassin
force-pushed
the
improve-linter-warnings
branch
from
November 1, 2026 20:30
76087c7 to
0f8148d
Compare
Member
Author
|
@probonopd asked me to merge this without any further review. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CC #138, @Jojo-Schmitz, @Samueru-sama, @knarfS, @kazam0180, @ivan-hc