Repository navigation
Drop the old ways of building a uri on the segments - #25
Merged
Merged
Conversation
canonicalUriFor: and uriFor:resourceRoute: on the segments and the uri space, nodeMatchingScope: and matchesScope:in:, and matchesScope: on the route match and the resource route were the way uris were built before HOPUriBuilder. Nothing calls them any more: the builder walks the tree and asks the uri space whether a resource is in scope. With them, HOP-Core no longer sends asApptiveExternalId or isIdenticalTo: and no longer names AGUser. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
canonicalUriFor: and uriFor:resourceRoute: on the segments and the uri space, nodeMatchingScope: and matchesScope:in:, and matchesScope: on the route match and the resource route were the way uris were built before HOPUriBuilder. Nothing calls them any more: the builder walks the tree and asks the uri space whether a resource is in scope.
With them, HOP-Core no longer sends asApptiveExternalId or isIdenticalTo: and no longer names AGUser.