AQI-11668: add ScheduledActivity model used for storing in actor state

[mathitharmalingam-aqi]

No description provided.

[Copilot]

Copilot review overview

🟡 Changes recommended

Clean builds omit generated sources, while CI unnecessarily executes generation twice.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 1

Open (1)

• CI runs the code generator twice · New

What changed in this PR

Adds support for generating and packaging the new scheduled activity protobuf models.

Changes:

• Updates package version metadata.
• Integrates protobuf generation into compilation and improves script error handling.
• Documents the new models.

File	Description
ONE.Models.CSharp.csproj	Updates versioning and adds generation target.
BuildSubmodule.bat	Improves path and failure handling.
CHANGELOG.md	Records scheduled activity models.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Copilot review overview

🟡 Changes recommended

The submodule update is missing, and clean builds will not include sources generated after project evaluation.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 2 · 1

Open (3)

• Submodule revision lacks the declared ScheduledActivity protos · New
• Generated sources are omitted from Compile after project evaluation · New
• CI runs the code generator twice

[Copilot]

Copilot review overview

🟡 Changes recommended

Release versioning, undocumented protocol additions, and incomplete generator failure propagation could produce an incorrect package.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 1 · 1 · 1

Open (3)

• Fail generation when any protoc command fails · New
• CI runs the code generator twice
• Document or exclude additional public models in the release · New

Resolved since last review (2)

• Generated sources are omitted from Compile after project evaluation
• Submodule revision lacks the declared ScheduledActivity protos

Previously missed (1)

In code that hasn't changed since last review

Clear VersionSuffix for release version consistency

src/​ONE.Models.CSharp/​ONE.Models.CSharp.csproj:8

The release workflow builds this project without overriding VersionSuffix, so merging this branch will publish 7.35.0-AQI-11668-1 from build-main.yml, while the changelog declares the release as 7.35.0. The project comment also requires the suffix to be removed for release packages; leave it empty so the main-branch publication and release notes agree.

[Copilot]

Copilot review overview

🟡 Changes recommended

The configured suffix would publish a prerelease package despite the changelog declaring version 7.35.0.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 2 · 1 · 1

Open (4)

• Clear version suffix for stable release packaging · New
• Fail generation when any protoc command fails
• CI runs the code generator twice
• Document or exclude additional public models in the release

[Copilot]

Copilot review overview

🟢 Approval recommended

All reviewed changes are consistent, and no unresolved issues were identified.

Review effort: Balanced
Findings: 1 · 1 · 1

Open (3)

• Fail generation when any protoc command fails
• CI runs the code generator twice
• Document or exclude additional public models in the release

Resolved since last review (1)

• Clear version suffix for stable release packaging

[Copilot]

Copilot review overview

🟡 Changes recommended

The 7.35.0 changelog date incorrectly precedes the 7.34.0 release date.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 1 · 1 · 2

Open (4)

• Fail generation when any protoc command fails
• CI runs the code generator twice
• Correct 7.35.0 release date ordering · New
• Document or exclude additional public models in the release

[Copilot]

Copilot review overview

🔵 Needs a closer look

The 7.35.0 changelog date conflicts with the established release chronology.

Review effort: Balanced
Findings: 1 · 1 · 1

Open (3)

• Fail generation when any protoc command fails
• CI runs the code generator twice
• Document or exclude additional public models in the release

Resolved since last review (1)

• Correct 7.35.0 release date ordering

[Copilot]

Copilot review overview

🟡 Changes recommended

The MSBuild target makes non-Windows builds fail by unconditionally invoking a Windows batch command.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 2 · 1 · 1

Open (4)

• Cross-platform builds fail due to Windows-only generation target · New
• Fail generation when any protoc command fails
• CI runs the code generator twice
• Document or exclude additional public models in the release

[mathitharmalingam-aqi]

The batch file usage is not new - it was part of the github action.