Skip to content

Fix two typos in user-facing strings - #4016

Merged
allilevine merged 1 commit into
trunkfrom
fix/user-facing-typos
Nov 4, 2026
Merged

allilevine merged 1 commit into
trunkfrom
fix/user-facing-typos

Conversation

@allilevine

Copy link
Copy Markdown
Member

Fixes #

Proposed changes:

  • templates/emails/parts/footer.php — "You are receiving this emails because of your ActivityPub plugin settings." → "this email". This footer is shared by all four notification emails (stats report, new follower, new mention, new DM), so it corrects the line everywhere.
  • includes/wp-admin/class-dashboard.php — the ActivityPub Author Profile widget said "Authors who can not access this settings page"; the rest of the plugin uses "cannot" (for example the uploads-directory health check).

Both strings are translatable, so the existing translations of these two sentences drop back to English until a translator re-approves them. translate.wordpress.org will offer the old translation as a near-100% translation-memory match, so it's a one-click re-approval rather than a retranslation.

Other information:

  • Have you written new tests for your changes, if applicable?

Copy-only change, no new tests. Existing mailer and dashboard tests pass (39 tests), and neither string is asserted on anywhere in the suite.

These two were the only genuine typos found in a sweep of all 1393 translatable strings (generated a POT, then ran a stemming spell check plus doubled-word, spacing, a/an and subject-verb agreement passes).

One thing deliberately left out: 11 prose strings use lowercase "fediverse" where the plugin otherwise treats it as a proper noun, e.g. class-user-settings-fields.php:188 and class-classic-editor.php:190. That is real drift, but it is an editorial call rather than a typo and would invalidate 11 more translations, so it seems better as its own issue.

Testing instructions:

  1. Go to Dashboard → Home and look at the ActivityPub Author Profile widget. The sentence below the profile URL should read "Authors who cannot access this settings page…".
  2. Trigger any ActivityPub notification email — the quickest is a stats report:
wp eval '
update_user_option( 1, "activitypub_mailer_monthly_report", "1" );
update_option( Activitypub\Statistics::get_monthly_option_name( 1, 2026, 9 ), array( "posts_count" => 4, "followers_count" => 7, "followers_total" => 142 ) );
add_filter( "pre_wp_mail", function ( $sc, $atts ) { file_put_contents( ABSPATH . "wp-content/email.html", $atts["message"] ); return true; }, 10, 2 );
Activitypub\Scheduler\Statistics::send_monthly_email( 1, 2026, 9, true );
'
  1. Open /wp-content/email.html. The footer should read "You are receiving this email because of your ActivityPub plugin settings."

Changelog entry

Changelog entry added in .github/changelog/fix-user-facing-typos (Patch / Fixed).

The notification email footer read "You are receiving this emails", and
the ActivityPub Author Profile dashboard widget read "can not" where the
rest of the plugin uses "cannot".
Copilot AI balanced review requested due to automatic review settings November 4, 2026 21:32
@allilevine allilevine self-assigned this Nov 4, 2026
@allilevine
allilevine requested a review from a team November 4, 2026 21:32

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the user-facing wording corrections and accompanying changelog entry.

No open issues 🎉

What changed in this PR

Corrects two user-facing wording mistakes in the ActivityPub plugin without changing functionality.

Changes:

  • Fixes “this emails” to “this email” in the shared notification footer.
  • Changes “can not” to “cannot” in the Author Profile dashboard widget.
  • Adds a patch changelog entry documenting both corrections.
File Description
templates/​emails/​parts/​footer.php Corrects the shared notification email footer.
includes/​wp-admin/​class-dashboard.php Corrects wording in the Author Profile widget.
.github/​changelog/​fix-user-facing-typos Documents the wording fixes for users.

Review effort: Balanced

@allilevine
allilevine merged commit 342c17e into trunk Nov 4, 2026
12 checks passed
@allilevine
allilevine deleted the fix/user-facing-typos branch November 4, 2026 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants