Skip to content

ESTree modernization: build, standalone treegen module, engine fixes, CI - #13

Merged
Blamad merged 114 commits into
masterfrom
merge-to-master
Oct 26, 2026
Merged

Blamad merged 114 commits into
masterfrom
merge-to-master

Conversation

@Blamad

@Blamad Blamad commented Oct 25, 2026

Copy link
Copy Markdown
Owner

Summary

Modernizes the engine in place and isolates the Lindenmayer tree generation into a standalone, deterministic module.

  • Build: CMake ≥ 3.21 with presets, C++17, no Boost (and no environment variable needed), refreshed dependencies (GLFW 3.4, glm 1.0.3, Bullet 3.25, FreeType 2.15.0).
  • treegen (ESEngine/TreeGen/): pure C++17 static library (std + glm + rapidjson only, boundary enforced by a CTest) with seeded, reproducible loaders → rewriter → turtle → geometry → generateTree; the legacy Lindenmayer* classes are gone and LindenmayerTree is a thin adapter. Headless treegen_cli writes OBJ files.
  • Fixes: 14 documented regex loader/solver defects, crashes on malformed rule files and unbalanced brackets, fixed GL buffer caps, NaN geometry, engine ownership/destruction bugs (T10), the tropism no-op (now works, see docs/DECISIONS.md D-010/D-016), discrete-GPU hint for Optimus laptops.
  • Tests & CI: doctest + CTest (232 tests), golden data for every shipped rule file, GitHub Actions (Windows MSVC Debug/Release with the engine, Linux GCC engine ON/OFF) — green on modernization.
  • Docs: CLAUDE.md and docs/ (plan, decisions D-001…D-020, per-task reports, owner checklist in docs/tasks/T13-modernization-gate/SUMMARY.md).

This branch is modernization merged into the current master (b8a5d45); the only conflict was README.md (README rewritten, the "executable in the release tab" note kept and reworded because v1.0 is the pre-modernization 2020 state).

Notes for review

  • Trees using tropism T (ternary A–E, scene 0) now droop towards the tropism as designed; in the old binary T was a no-op because of a zero glm::quat() start (D-010).
  • legacy/parametricTree2.l had a typo ([^+a)), restored as [^+(a) — other readings are possible (D-017).
  • Open manual checks are listed in the SUMMARY checklist; the engine runs only on the NVIDIA GPU (Intel HD 530 driver crash, in the backlog).

🤖 Generated with Claude Code

Blamad and others added 30 commits October 25, 2026 10:01
CLAUDE.md with repo rules, docs/PLAN.md master plan, treegen design
contract, and per-task directories (T00-T13) with briefs and plan stubs.
CLAUDE.local.md is git-ignored.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Presets vs2019/vs2026/ninja-msvc, scripts/msvc-env.cmd, preset-based
setup.bat, BOOST_LIB variable with vc140 libs and BOOST_ALL_NO_LIB,
bcrypt link for boost::uuids, <string> include in Texture.h.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
ESTree.exe crashed in ig9icd64.dll (Intel HD 530) on the Optimus laptop,
identically in the 2020 binary. Export NvOptimusEnablement and
AmdPowerXpressRequestHighPerformance; record findings in REPORT/BACKLOG.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…h std

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
getComponentAs<T>/getComponentsAs<T>(ComponentType) on GameObject and Component;
Component and GameObject get virtual destructors (debug builds assert the cast).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…uard)

~Scene unregisters bodies/lights, destroys the objects while the managers are alive.
removeGameObject ignores unknown objects and makes MouseManager forget the object.
LightsManager::removeLight no longer erases an uninitialised pointer.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Bullet world/bodies/shapes are deleted; UIManager no longer release()s its components;
virtual destructors for Window, Renderer, VertexArray, FrameBuffer, UIComponent (C5205);
InputState dtor no longer deletes by-value members, GLWindow no longer release()s it;
Engine::~Engine destroys scene, renderer, window in reverse order of construction;
GLWindow key callback state initialised (C4701).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…wnership tests

ninja-msvc-asan / vs2019-asan presets. The x64 ASan runtime only exists in the VS 2019
Build Tools here; its CRT DLLs are copied next to each executable (System32 has a newer
vcruntime that makes the ASan runtime fail with 0xC0000142).
tests/engine: GameObject/Transform, InputState and PhysicsManager/RigidBody tests.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…strumented too

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Resolved conflict in LightsManager.cpp: range-for (T09) with
static_cast (T10).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Blamad and others added 29 commits October 25, 2026 17:10
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Resolved DECISIONS.md: T07 keeps D-017; the T08 decision is renumbered
to D-018 (both tasks had chosen D-017).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ests README

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…fects)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…tion)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…er; engine ON failed to configure on Linux)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…itive file systems

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…er-config cache keys

First GitHub run failed: PowerShell split -DCMAKE_POLICY_VERSION_MINIMUM=3.5 at the dot
(Windows), and the Linux engine-OFF job restored a FetchContent sub-build written by a
different generator (Unix Makefiles vs Ninja).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Build modernization (CMake presets, C++17, no Boost, dependency refresh), the standalone
treegen module with tests/CLI/OBJ export, engine ownership fixes, CI.

README conflict resolved: modernization's rewrite kept, master's "executable in the
release tab" note folded in (the v1.0 release is the pre-modernization 2020 state).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@Blamad
Blamad merged commit 6f9d34c into master Oct 26, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant