Repository navigation
ESTree modernization: build, standalone treegen module, engine fixes, CI - #13
Merged
Merged
Conversation
CLAUDE.md with repo rules, docs/PLAN.md master plan, treegen design contract, and per-task directories (T00-T13) with briefs and plan stubs. CLAUDE.local.md is git-ignored. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Presets vs2019/vs2026/ninja-msvc, scripts/msvc-env.cmd, preset-based setup.bat, BOOST_LIB variable with vc140 libs and BOOST_ALL_NO_LIB, bcrypt link for boost::uuids, <string> include in Texture.h. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
ESTree.exe crashed in ig9icd64.dll (Intel HD 530) on the Optimus laptop, identically in the 2020 binary. Export NvOptimusEnablement and AmdPowerXpressRequestHighPerformance; record findings in REPORT/BACKLOG. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…h std Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
getComponentAs<T>/getComponentsAs<T>(ComponentType) on GameObject and Component; Component and GameObject get virtual destructors (debug builds assert the cast). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…uard) ~Scene unregisters bodies/lights, destroys the objects while the managers are alive. removeGameObject ignores unknown objects and makes MouseManager forget the object. LightsManager::removeLight no longer erases an uninitialised pointer. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Bullet world/bodies/shapes are deleted; UIManager no longer release()s its components; virtual destructors for Window, Renderer, VertexArray, FrameBuffer, UIComponent (C5205); InputState dtor no longer deletes by-value members, GLWindow no longer release()s it; Engine::~Engine destroys scene, renderer, window in reverse order of construction; GLWindow key callback state initialised (C4701). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…wnership tests ninja-msvc-asan / vs2019-asan presets. The x64 ASan runtime only exists in the VS 2019 Build Tools here; its CRT DLLs are copied next to each executable (System32 has a newer vcruntime that makes the ASan runtime fail with 0xC0000142). tests/engine: GameObject/Transform, InputState and PhysicsManager/RigidBody tests. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…strumented too Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Resolved conflict in LightsManager.cpp: range-for (T09) with static_cast (T10). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Resolved DECISIONS.md: T07 keeps D-017; the T08 decision is renumbered to D-018 (both tasks had chosen D-017). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ests README Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…fects) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…tion) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…er; engine ON failed to configure on Linux) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…itive file systems Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…er-config cache keys First GitHub run failed: PowerShell split -DCMAKE_POLICY_VERSION_MINIMUM=3.5 at the dot (Windows), and the Linux engine-OFF job restored a FetchContent sub-build written by a different generator (Unix Makefiles vs Ninja). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Build modernization (CMake presets, C++17, no Boost, dependency refresh), the standalone treegen module with tests/CLI/OBJ export, engine ownership fixes, CI. README conflict resolved: modernization's rewrite kept, master's "executable in the release tab" note folded in (the v1.0 release is the pre-modernization 2020 state). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modernizes the engine in place and isolates the Lindenmayer tree generation into a standalone, deterministic module.
treegen(ESEngine/TreeGen/): pure C++17 static library (std + glm + rapidjson only, boundary enforced by a CTest) with seeded, reproducible loaders → rewriter → turtle → geometry →generateTree; the legacyLindenmayer*classes are gone andLindenmayerTreeis a thin adapter. Headlesstreegen_cliwrites OBJ files.docs/DECISIONS.mdD-010/D-016), discrete-GPU hint for Optimus laptops.modernization.CLAUDE.mdanddocs/(plan, decisions D-001…D-020, per-task reports, owner checklist indocs/tasks/T13-modernization-gate/SUMMARY.md).This branch is
modernizationmerged into the currentmaster(b8a5d45); the only conflict wasREADME.md(README rewritten, the "executable in the release tab" note kept and reworded becausev1.0is the pre-modernization 2020 state).Notes for review
T(ternary A–E, scene 0) now droop towards the tropism as designed; in the old binaryTwas a no-op because of a zeroglm::quat()start (D-010).legacy/parametricTree2.lhad a typo ([^+a)), restored as[^+(a)— other readings are possible (D-017).🤖 Generated with Claude Code