Skip to content

Add missing includes - #236

Merged
mintar merged 1 commit into
CCNYRoboticsLab:rollingfrom
wentasah:add-includes
Sep 9, 2026
Merged

mintar merged 1 commit into
CCNYRoboticsLab:rollingfrom
wentasah:add-includes

Conversation

@wentasah

@wentasah wentasah commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Without these, I get the following build errors in latest rolling:

/build/imu_tools-release-release-rolling-rviz_imu_plugin-2.2.4-2/src/imu_display.cpp: In member function 'virtual void rviz_imu_plugin::ImuDisplay::onEnable()':
/build/imu_tools-release-release-rolling-rviz_imu_plugin-2.2.4-2/src/imu_display.cpp:67:16: error: invalid use of incomplete type 'class Ogre::SceneNode'
   67 |     scene_node_->setVisible(true);
      |                ^~
In file included from /build/imu_tools-release-release-rolling-rviz_imu_plugin-2.2.4-2/src/imu_display.h:37,
                 from /build/imu_tools-release-release-rolling-rviz_imu_plugin-2.2.4-2/src/imu_display.cpp:31:
/nix/store/h70jr156g5i17ppcyhfhpvrrxf7zs0li-ros-rolling-rviz-common-16.0.3-r1/include/rviz_common/rviz_common/display.hpp:52:7: note: forward declaration of 'class Ogre::SceneNode'
   52 | class SceneNode;
      |       ^~~~~~~~~
/build/imu_tools-release-release-rolling-rviz_imu_plugin-2.2.4-2/src/imu_display.cpp: In member function 'virtual void rviz_imu_plugin::ImuDisplay::onDisable()':
/build/imu_tools-release-release-rolling-rviz_imu_plugin-2.2.4-2/src/imu_display.cpp:78:16: error: invalid use of incomplete type 'class Ogre::SceneNode'
   78 |     scene_node_->setVisible(false);
      |                ^~
/nix/store/h70jr156g5i17ppcyhfhpvrrxf7zs0li-ros-rolling-rviz-common-16.0.3-r1/include/rviz_common/rviz_common/display.hpp:52:7: note: forward declaration of 'class Ogre::SceneNode'
   52 | class SceneNode;
      |       ^~~~~~~~~
/build/imu_tools-release-release-rolling-rviz_imu_plugin-2.2.4-2/src/imu_display.cpp: In member function 'virtual void rviz_imu_plugin::ImuDisplay::onInitialize()':
/build/imu_tools-release-release-rolling-rviz_imu_plugin-2.2.4-2/src/imu_display.cpp:86:33: error: invalid use of incomplete type 'class Ogre::SceneManager'
   86 |     scene_node_ = scene_manager_->getRootSceneNode()->createChildSceneNode();
      |                                 ^~
/nix/store/h70jr156g5i17ppcyhfhpvrrxf7zs0li-ros-rolling-rviz-common-16.0.3-r1/include/rviz_common/rviz_common/display.hpp:51:7: note: forward declaration of 'class Ogre::SceneManager'
   51 | class SceneManager;
      |       ^~~~~~~~~~~~
/build/imu_tools-release-release-rolling-rviz_imu_plugin-2.2.4-2/src/imu_display.cpp:98:16: error: invalid use of incomplete type 'class Ogre::SceneNode'
   98 |     scene_node_->setVisible(isEnabled());
      |                ^~
/nix/store/h70jr156g5i17ppcyhfhpvrrxf7zs0li-ros-rolling-rviz-common-16.0.3-r1/include/rviz_common/rviz_common/display.hpp:52:7: note: forward declaration of 'class Ogre::SceneNode'
   52 | class SceneNode;
      |       ^~~~~~~~~
/build/imu_tools-release-release-rolling-rviz_imu_plugin-2.2.4-2/src/mag_display.cpp: In member function 'virtual void rviz_imu_plugin::MagDisplay::onEnable()':
/build/imu_tools-release-release-rolling-rviz_imu_plugin-2.2.4-2/src/mag_display.cpp:50:16: error: invalid use of incomplete type 'class Ogre::SceneNode'
   50 |     scene_node_->setVisible(true);
      |                ^~
In file included from /build/imu_tools-release-release-rolling-rviz_imu_plugin-2.2.4-2/src/mag_display.h:37,
                 from /build/imu_tools-release-release-rolling-rviz_imu_plugin-2.2.4-2/src/mag_display.cpp:31:
/nix/store/h70jr156g5i17ppcyhfhpvrrxf7zs0li-ros-rolling-rviz-common-16.0.3-r1/include/rviz_common/rviz_common/display.hpp:52:7: note: forward declaration of 'class Ogre::SceneNode'
   52 | class SceneNode;
      |       ^~~~~~~~~
/build/imu_tools-release-release-rolling-rviz_imu_plugin-2.2.4-2/src/mag_display.cpp: In member function 'virtual void rviz_imu_plugin::MagDisplay::onDisable()':
/build/imu_tools-release-release-rolling-rviz_imu_plugin-2.2.4-2/src/mag_display.cpp:59:16: error: invalid use of incomplete type 'class Ogre::SceneNode'
   59 |     scene_node_->setVisible(false);
      |                ^~
/nix/store/h70jr156g5i17ppcyhfhpvrrxf7zs0li-ros-rolling-rviz-common-16.0.3-r1/include/rviz_common/rviz_common/display.hpp:52:7: note: forward declaration of 'class Ogre::SceneNode'
   52 | class SceneNode;
      |       ^~~~~~~~~
/build/imu_tools-release-release-rolling-rviz_imu_plugin-2.2.4-2/src/mag_display.cpp: In member function 'virtual void rviz_imu_plugin::MagDisplay::onInitialize()':
/build/imu_tools-release-release-rolling-rviz_imu_plugin-2.2.4-2/src/mag_display.cpp:67:33: error: invalid use of incomplete type 'class Ogre::SceneManager'
   67 |     scene_node_ = scene_manager_->getRootSceneNode()->createChildSceneNode();
      |                                 ^~
/nix/store/h70jr156g5i17ppcyhfhpvrrxf7zs0li-ros-rolling-rviz-common-16.0.3-r1/include/rviz_common/rviz_common/display.hpp:51:7: note: forward declaration of 'class Ogre::SceneManager'
   51 | class SceneManager;
      |       ^~~~~~~~~~~~
/build/imu_tools-release-release-rolling-rviz_imu_plugin-2.2.4-2/src/mag_display.cpp:72:16: error: invalid use of incomplete type 'class Ogre::SceneNode'
   72 |     scene_node_->setVisible(isEnabled());
      |                ^~
/nix/store/h70jr156g5i17ppcyhfhpvrrxf7zs0li-ros-rolling-rviz-common-16.0.3-r1/include/rviz_common/rviz_common/display.hpp:52:7: note: forward declaration of 'class Ogre::SceneNode'
   52 | class SceneNode;
      |       ^~~~~~~~~

Without these, I get the following build errors in latest rolling:

    /build/imu_tools-release-release-rolling-rviz_imu_plugin-2.2.4-2/src/imu_display.cpp: In member function 'virtual void rviz_imu_plugin::ImuDisplay::onEnable()':
    /build/imu_tools-release-release-rolling-rviz_imu_plugin-2.2.4-2/src/imu_display.cpp:67:16: error: invalid use of incomplete type 'class Ogre::SceneNode'
       67 |     scene_node_->setVisible(true);
          |                ^~
    In file included from /build/imu_tools-release-release-rolling-rviz_imu_plugin-2.2.4-2/src/imu_display.h:37,
                     from /build/imu_tools-release-release-rolling-rviz_imu_plugin-2.2.4-2/src/imu_display.cpp:31:
    /nix/store/h70jr156g5i17ppcyhfhpvrrxf7zs0li-ros-rolling-rviz-common-16.0.3-r1/include/rviz_common/rviz_common/display.hpp:52:7: note: forward declaration of 'class Ogre::SceneNode'
       52 | class SceneNode;
          |       ^~~~~~~~~
    /build/imu_tools-release-release-rolling-rviz_imu_plugin-2.2.4-2/src/imu_display.cpp: In member function 'virtual void rviz_imu_plugin::ImuDisplay::onDisable()':
    /build/imu_tools-release-release-rolling-rviz_imu_plugin-2.2.4-2/src/imu_display.cpp:78:16: error: invalid use of incomplete type 'class Ogre::SceneNode'
       78 |     scene_node_->setVisible(false);
          |                ^~
    /nix/store/h70jr156g5i17ppcyhfhpvrrxf7zs0li-ros-rolling-rviz-common-16.0.3-r1/include/rviz_common/rviz_common/display.hpp:52:7: note: forward declaration of 'class Ogre::SceneNode'
       52 | class SceneNode;
          |       ^~~~~~~~~
    /build/imu_tools-release-release-rolling-rviz_imu_plugin-2.2.4-2/src/imu_display.cpp: In member function 'virtual void rviz_imu_plugin::ImuDisplay::onInitialize()':
    /build/imu_tools-release-release-rolling-rviz_imu_plugin-2.2.4-2/src/imu_display.cpp:86:33: error: invalid use of incomplete type 'class Ogre::SceneManager'
       86 |     scene_node_ = scene_manager_->getRootSceneNode()->createChildSceneNode();
          |                                 ^~
    /nix/store/h70jr156g5i17ppcyhfhpvrrxf7zs0li-ros-rolling-rviz-common-16.0.3-r1/include/rviz_common/rviz_common/display.hpp:51:7: note: forward declaration of 'class Ogre::SceneManager'
       51 | class SceneManager;
          |       ^~~~~~~~~~~~
    /build/imu_tools-release-release-rolling-rviz_imu_plugin-2.2.4-2/src/imu_display.cpp:98:16: error: invalid use of incomplete type 'class Ogre::SceneNode'
       98 |     scene_node_->setVisible(isEnabled());
          |                ^~
    /nix/store/h70jr156g5i17ppcyhfhpvrrxf7zs0li-ros-rolling-rviz-common-16.0.3-r1/include/rviz_common/rviz_common/display.hpp:52:7: note: forward declaration of 'class Ogre::SceneNode'
       52 | class SceneNode;
          |       ^~~~~~~~~
    /build/imu_tools-release-release-rolling-rviz_imu_plugin-2.2.4-2/src/mag_display.cpp: In member function 'virtual void rviz_imu_plugin::MagDisplay::onEnable()':
    /build/imu_tools-release-release-rolling-rviz_imu_plugin-2.2.4-2/src/mag_display.cpp:50:16: error: invalid use of incomplete type 'class Ogre::SceneNode'
       50 |     scene_node_->setVisible(true);
          |                ^~
    In file included from /build/imu_tools-release-release-rolling-rviz_imu_plugin-2.2.4-2/src/mag_display.h:37,
                     from /build/imu_tools-release-release-rolling-rviz_imu_plugin-2.2.4-2/src/mag_display.cpp:31:
    /nix/store/h70jr156g5i17ppcyhfhpvrrxf7zs0li-ros-rolling-rviz-common-16.0.3-r1/include/rviz_common/rviz_common/display.hpp:52:7: note: forward declaration of 'class Ogre::SceneNode'
       52 | class SceneNode;
          |       ^~~~~~~~~
    /build/imu_tools-release-release-rolling-rviz_imu_plugin-2.2.4-2/src/mag_display.cpp: In member function 'virtual void rviz_imu_plugin::MagDisplay::onDisable()':
    /build/imu_tools-release-release-rolling-rviz_imu_plugin-2.2.4-2/src/mag_display.cpp:59:16: error: invalid use of incomplete type 'class Ogre::SceneNode'
       59 |     scene_node_->setVisible(false);
          |                ^~
    /nix/store/h70jr156g5i17ppcyhfhpvrrxf7zs0li-ros-rolling-rviz-common-16.0.3-r1/include/rviz_common/rviz_common/display.hpp:52:7: note: forward declaration of 'class Ogre::SceneNode'
       52 | class SceneNode;
          |       ^~~~~~~~~
    /build/imu_tools-release-release-rolling-rviz_imu_plugin-2.2.4-2/src/mag_display.cpp: In member function 'virtual void rviz_imu_plugin::MagDisplay::onInitialize()':
    /build/imu_tools-release-release-rolling-rviz_imu_plugin-2.2.4-2/src/mag_display.cpp:67:33: error: invalid use of incomplete type 'class Ogre::SceneManager'
       67 |     scene_node_ = scene_manager_->getRootSceneNode()->createChildSceneNode();
          |                                 ^~
    /nix/store/h70jr156g5i17ppcyhfhpvrrxf7zs0li-ros-rolling-rviz-common-16.0.3-r1/include/rviz_common/rviz_common/display.hpp:51:7: note: forward declaration of 'class Ogre::SceneManager'
       51 | class SceneManager;
          |       ^~~~~~~~~~~~
    /build/imu_tools-release-release-rolling-rviz_imu_plugin-2.2.4-2/src/mag_display.cpp:72:16: error: invalid use of incomplete type 'class Ogre::SceneNode'
       72 |     scene_node_->setVisible(isEnabled());
          |                ^~
    /nix/store/h70jr156g5i17ppcyhfhpvrrxf7zs0li-ros-rolling-rviz-common-16.0.3-r1/include/rviz_common/rviz_common/display.hpp:52:7: note: forward declaration of 'class Ogre::SceneNode'
       52 | class SceneNode;
          |       ^~~~~~~~~
@mintar
mintar merged commit b5d129d into CCNYRoboticsLab:rolling Sep 9, 2026
1 check passed
@mintar

mintar commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Thank you, merged!

Note to self: This build error could not be reproduced on the Github CI, because the CI uses the ros:rolling-ros-core Docker image, which still ships with the older versions of the dependencies, so it doesn't cause this build error. The Jenkins build farm however has the same errors that this PR is fixing: https://build.ros2.org/job/Rbin_unv8_uRv8__rviz_imu_plugin__ubuntu_resolute_arm64__binary/39/display/redirect

@wentasah
wentasah deleted the add-includes branch September 9, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants