Repository navigation
fix(streaming): cancel upstream and free codec when listener cancels - #6
Merged
Merged
Conversation
StreamOpusEncoder/StreamOpusDecoder.bind were async* generators parked in await for, so cancelling while the source was idle hung forever, never cancelled upstream and leaked the native codec. Bind through a StreamController that destroys the codec and cancels upstream on cancel. StreamOpusDecoder now also destroys its decoder and exposes destroy(). Fixes EPNW#21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StreamOpusEncoder.bindandStreamOpusDecoder.bindwereasync*generators parked inawait for. Cancelling while the source was idle never reached the generator, so upstream was never cancelled and the native codec leaked.StreamController(_bindNative) that destroys the codec and cancels upstream on cancel, and forwards pause/resume.StreamOpusDecodernow also destroys its decoder on cancel and exposesdestroy().Fixes EPNW#21
Test plan
opus_dart_streaming_mock_test.dartextended with cancel-while-idle coveragedart testinopus_dart🤖 Generated with Claude Code