Skip to content

Skip getting a server candidate if unnecessary - #2948

Closed
lifenjoiner wants to merge 2 commits into
DNSCrypt:masterfrom
lifenjoiner:bypass
Closed

lifenjoiner wants to merge 2 commits into
DNSCrypt:masterfrom
lifenjoiner:bypass

Conversation

@lifenjoiner

Copy link
Copy Markdown
Member

Reduce locks.

Passing a *Proxy seems not elegant. But, it works, and avoids redoing unpack and repack the packets to add EDNS0 Padding outside ApplyQueryPlugins.

@jedisct1

jedisct1 commented Sep 7, 2025

Copy link
Copy Markdown
Member

Avoiding passing *Proxy around would be better

An alternative could be to pass a getServerInfo function pointer to the plugins, so that the function is called only when necessary.

@lifenjoiner lifenjoiner closed this Sep 7, 2025
@lifenjoiner
lifenjoiner deleted the bypass branch September 10, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants