Skip to content

chore: upgrade findable-ui to latest (v62.0.0) - #3316

Open
MillenniumFalconMechanic wants to merge 2 commits into
mainfrom
millenniumfalconmechanic/3315-findable-ui-v61
Open

MillenniumFalconMechanic wants to merge 2 commits into
mainfrom
millenniumfalconmechanic/3315-findable-ui-v61

Conversation

@MillenniumFalconMechanic

@MillenniumFalconMechanic MillenniumFalconMechanic commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Closes #3315

What changed

  • @databiosphere/findable-ui goes from ^60.0.0 to ^62.0.0, and the lockfile resolves 62.0.0. The issue first targeted 61.0.0; 62.0.0 was released while this pull request was open, so it was bumped again.
  • ky goes from ^1 to ^1.10.0. data-portal does not import ky; it is a direct dependency only to satisfy findable-ui's peer range, so this range follows findable-ui's new peer floor. The lockfile already resolved 1.14.3, so the installed version does not change.
  • npm audit fix (without --force) updated the lockfile. Besides the findable-ui bump, the lockfile now has these dev-only, in-range updates from the audit fix:
    • typescript-eslint and the @typescript-eslint/* packages, 8.72.1 to 8.73.0
    • brace-expansion, 5.0.12 to 5.0.13
    • the minimatch nested under @typescript-eslint/typescript-estree, 10.2.6 to 11.0.9, which adds @isaacs/nonrecursive-glob-match 1.1.0

No source files changed.

Audit

moderate high critical
Before npm audit fix 10 0 0
After npm audit fix 4 0 0

The 4 advisories left are all in dev tooling:

  • @digitak/esrun and its esbuild: npm reports no fix available.
  • eslint-plugin-sonarjs and its minimatch: npm's only suggested fix is a downgrade to eslint-plugin-sonarjs 2.0.0, so it stays as is.

Why

findable-ui 62.0.0 is the latest release. The breaking changes in 61.0.0 and 62.0.0 do not touch any API data-portal uses:

  • 61.0.0: data-portal does not import closeAndRestoreFocus, the filter Checkbox, isNodeBoolean or useEntityList, it sets versionInfo: true, and its defaultListParams holds only size.
  • 62.0.0: data-portal does not use the changed Export props (setFileManifestFormat, manifestDownloadFormat), the Search All Filters internals, or the UseBarCount and Chart utils.

62.0.0 has the same peer dependencies as 61.0.0.

62.0.0 also fixes analytics.css tooltips, but the analytics site uses its own committed copy at analytics/site/analytics.css, so this pull request does not pick that fix up.

Assumptions I made

  • The typescript-eslint and minimatch bumps that npm audit fix made are kept in this pull request, because running the audit fix was agreed as part of this upgrade, and are listed above so a bisect or revert is clear.
  • ky stays a direct dependency, pinned to findable-ui's peer floor; the next findable-ui upgrade that raises that floor needs the same edit.

How to verify

Definition of done from #3315:

  • @databiosphere/findable-ui is on ^62.0.0, and the lockfile resolves 62.0.0. (step 1)
  • Typecheck, lint, format check and build pass. (step 2)
  • The footer, the data dictionary column filters and the atlas source datasets column filters work as before. (steps 3 to 5)
  1. Run node -p "require('./node_modules/@databiosphere/findable-ui/package.json').version" after npm ci. It prints 62.0.0.
  2. Run npx tsc --noEmit, npm run lint, npm run check-format and npm run build-dev:data-portal. All pass; lint reports 0 errors.
  3. Run npm run dev and open /metadata/tier-1. Open the "Required" column filter: focus moves into the panel. Choose "Strongly Recommended": the table shows only those fields. Press Escape: the panel closes and focus returns to the "Required" button.
  4. Open /hca-bio-networks/gut/atlases/gut-v1-0/source-datasets at 1440px. Open the "Assay" filter: the panel opens below the button, aligned to its left edge, with no backdrop, and the page still scrolls. Choose a value: the table filters. Press Escape: focus returns to the button.
  5. Scroll to the footer. It looks the same as production, including the version chip.
  6. Click "Help" in the header. The menu opens and focus moves to its first item, "Get Help".

Plan

  1. In package.json, set @databiosphere/findable-ui to ^61.0.0 and ky to ^1.10.0, then run npm install to update package-lock.json.
  2. Record the npm audit counts, run npm audit fix (without --force), and record the counts again.
  3. Run typecheck, lint, the format check and the build, and fix any errors the upgrade causes.
  4. Run the dev server and check the footer and the column filters.

Deviations

  • The upgrade targets findable-ui 62.0.0 instead of 61.0.0, at the reviewer's request after 62.0.0 was released. The checks in steps 3 and 4 were re-run on 62.0.0, plus the Help menu check.

🤖 Generated with Claude Code
🐦 Built with cc-claude-tools

Bump `@databiosphere/findable-ui` to `^61.0.0`, tighten `ky` to
findable-ui's new peer floor `^1.10.0`, and run `npm audit fix`
without `--force`.

Closes #3315

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: cc-claude-tools <cc-claude-tools@clevercanary.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The major UI dependency upgrade changes filter focus behavior, and required browser checks for data dictionary and atlas filters and the footer remain unchecked, requiring human runtime verification beyond the source snapshot.

No open issues 🎉

What changed in this PR

Updates data-portal to findable-ui 61.0.0 for #3315 and refreshes development dependencies through npm audit fix. No application source files change.

Changes:

  • Upgrades @databiosphere/findable-ui from ^60.0.0 to ^61.0.0.
  • Raises the ky range to ^1.10.0 to match findable-ui’s peer requirement; its locked version remains unchanged.
  • Updates development tooling dependencies, including typescript-eslint, brace-expansion and minimatch.
File Description
package.json Updates the findable-ui and ky dependency ranges.
package-lock.json Locks findable-ui to 61.0.0 and records peer metadata and development dependency updates.

Review effort: Balanced

@MillenniumFalconMechanic

Copy link
Copy Markdown
Contributor Author

Claude Code review: no defects found

npx tsc --noEmit passes against findable-ui 61.0.0. None of the v61 breaking changes affect this repo:

  • Removed or moved APIs: nothing imports closeAndRestoreFocus, the filter Checkbox, isNodeBoolean, useEntityList, buildListParams or the SSFetchSSFilter types.
  • Footer: versionInfo is still true, so the version chip still shows.
  • Entity list params: defaultListParams holds only size, and entities is [].
  • Node: minimatch 11 requires Node 20 || >=22, which Node 22.13.0 satisfies.

One note on the description: the npm audit fix updates aren't all in-range. The nested minimatch under @typescript-eslint/typescript-estree moves a major version (10.2.6 to 11.0.9).

🤖 Generated with Claude Code

findable-ui 62.0.0 was released after this branch was opened. None of
its breaking changes touch an API data-portal uses.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: cc-claude-tools <cc-claude-tools@clevercanary.com>
@MillenniumFalconMechanic MillenniumFalconMechanic changed the title chore: upgrade findable-ui to latest (v61.0.0) chore: upgrade findable-ui to latest (v62.0.0) Nov 19, 2026
@MillenniumFalconMechanic
MillenniumFalconMechanic requested a balanced review from Copilot November 19, 2026 22:33

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for the dependency-only update to findable-ui 62.0.0.

No open issues 🎉

Review effort: Balanced

@NoopDog NoopDog left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Mim. This is a clean upgrade: none of the APIs removed or renamed in findable-ui 61.0.0 and 62.0.0 are used in the portal's source, the lockfile changes are exactly the ones listed, everything resolves from the npm registry with matching integrity hashes, and minimatch 11 is the range @typescript-eslint/typescript-estree 8.73.0 asks for. npm ci, the production build, Prettier, ESLint and tsc pass at 77fc35d, and npm audit confirms 10 → 4 moderate advisories, all in dev tooling.

A few optional points:

  1. The description becomes the commit body, and one line has the eslint-plugin-sonarjs fix backwards. The installed version is 4.2.2, so npm's suggested fix is a downgrade to 2.0.0, not an upgrade. Something like "npm's only suggested fix is a downgrade to eslint-plugin-sonarjs 2.0.0, so it stays as is" would be accurate.
  2. The issue's browser checks (the footer version chip and the data dictionary and source-dataset filters) are still unticked in the description. If you ran them, ticking them would record it.
  3. For a later issue, not this PR: v62 gives heading anchor links an accessible name, and since the portal doesn't pass the new optional label, screen readers will hear the generic "Link to this section" (components/common/Typography/components/Heading/heading.tsx:23, and the data dictionary's FieldCell). Passing label would make those more specific.

@MillenniumFalconMechanic

Copy link
Copy Markdown
Contributor Author

Thanks, Dave. Point 1 is fixed in the description, and I ticked the two boxes your run at 77fc35da covers.

On point 3, I'm not filing a follow-up:

  • Heading never renders an anchor today. Its only use, in views/SearchView/searchView.tsx, passes enableAnchor={false}.
  • In FieldCell, each link now has the name "Link to this section" and sits in the same row as the field's title. That meets WCAG 2.4.4 (Link Purpose, In Context), so label would be a nice-to-have rather than a fix.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade findable-ui to latest (v62.0.0)

3 participants