Repository navigation
chore: upgrade findable-ui to latest (v62.0.0) - #3316
MillenniumFalconMechanic wants to merge 2 commits into
Conversation
Bump `@databiosphere/findable-ui` to `^61.0.0`, tighten `ky` to findable-ui's new peer floor `^1.10.0`, and run `npm audit fix` without `--force`. Closes #3315 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: cc-claude-tools <cc-claude-tools@clevercanary.com>
There was a problem hiding this comment.
🔵 Needs a closer look
The major UI dependency upgrade changes filter focus behavior, and required browser checks for data dictionary and atlas filters and the footer remain unchecked, requiring human runtime verification beyond the source snapshot.
No open issues 🎉
What changed in this PR
Updates data-portal to findable-ui 61.0.0 for #3315 and refreshes development dependencies through npm audit fix. No application source files change.
Changes:
- Upgrades
@databiosphere/findable-uifrom^60.0.0to^61.0.0. - Raises the
kyrange to^1.10.0to match findable-ui’s peer requirement; its locked version remains unchanged. - Updates development tooling dependencies, including typescript-eslint, brace-expansion and minimatch.
| File | Description |
|---|---|
package.json |
Updates the findable-ui and ky dependency ranges. |
package-lock.json |
Locks findable-ui to 61.0.0 and records peer metadata and development dependency updates. |
Review effort: Balanced
|
Claude Code review: no defects found
One note on the description: the 🤖 Generated with Claude Code |
findable-ui 62.0.0 was released after this branch was opened. None of its breaking changes touch an API data-portal uses. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: cc-claude-tools <cc-claude-tools@clevercanary.com>
NoopDog
left a comment
There was a problem hiding this comment.
Thanks, Mim. This is a clean upgrade: none of the APIs removed or renamed in findable-ui 61.0.0 and 62.0.0 are used in the portal's source, the lockfile changes are exactly the ones listed, everything resolves from the npm registry with matching integrity hashes, and minimatch 11 is the range @typescript-eslint/typescript-estree 8.73.0 asks for. npm ci, the production build, Prettier, ESLint and tsc pass at 77fc35d, and npm audit confirms 10 → 4 moderate advisories, all in dev tooling.
A few optional points:
- The description becomes the commit body, and one line has the
eslint-plugin-sonarjsfix backwards. The installed version is 4.2.2, so npm's suggested fix is a downgrade to 2.0.0, not an upgrade. Something like "npm's only suggested fix is a downgrade toeslint-plugin-sonarjs2.0.0, so it stays as is" would be accurate. - The issue's browser checks (the footer version chip and the data dictionary and source-dataset filters) are still unticked in the description. If you ran them, ticking them would record it.
- For a later issue, not this PR: v62 gives heading anchor links an accessible name, and since the portal doesn't pass the new optional
label, screen readers will hear the generic "Link to this section" (components/common/Typography/components/Heading/heading.tsx:23, and the data dictionary'sFieldCell). Passinglabelwould make those more specific.
|
Thanks, Dave. Point 1 is fixed in the description, and I ticked the two boxes your run at On point 3, I'm not filing a follow-up:
|
Closes #3315
What changed
@databiosphere/findable-uigoes from^60.0.0to^62.0.0, and the lockfile resolves 62.0.0. The issue first targeted 61.0.0; 62.0.0 was released while this pull request was open, so it was bumped again.kygoes from^1to^1.10.0. data-portal does not importky; it is a direct dependency only to satisfy findable-ui's peer range, so this range follows findable-ui's new peer floor. The lockfile already resolved 1.14.3, so the installed version does not change.npm audit fix(without--force) updated the lockfile. Besides the findable-ui bump, the lockfile now has these dev-only, in-range updates from the audit fix:typescript-eslintand the@typescript-eslint/*packages, 8.72.1 to 8.73.0brace-expansion, 5.0.12 to 5.0.13minimatchnested under@typescript-eslint/typescript-estree, 10.2.6 to 11.0.9, which adds@isaacs/nonrecursive-glob-match1.1.0No source files changed.
Audit
npm audit fixnpm audit fixThe 4 advisories left are all in dev tooling:
@digitak/esrunand itsesbuild: npm reports no fix available.eslint-plugin-sonarjsand itsminimatch: npm's only suggested fix is a downgrade toeslint-plugin-sonarjs2.0.0, so it stays as is.Why
findable-ui 62.0.0 is the latest release. The breaking changes in 61.0.0 and 62.0.0 do not touch any API data-portal uses:
closeAndRestoreFocus, the filterCheckbox,isNodeBooleanoruseEntityList, it setsversionInfo: true, and itsdefaultListParamsholds onlysize.setFileManifestFormat,manifestDownloadFormat), the Search All Filters internals, or theUseBarCountandChartutils.62.0.0 has the same peer dependencies as 61.0.0.
62.0.0 also fixes
analytics.csstooltips, but the analytics site uses its own committed copy atanalytics/site/analytics.css, so this pull request does not pick that fix up.Assumptions I made
minimatchbumps thatnpm audit fixmade are kept in this pull request, because running the audit fix was agreed as part of this upgrade, and are listed above so a bisect or revert is clear.kystays a direct dependency, pinned to findable-ui's peer floor; the next findable-ui upgrade that raises that floor needs the same edit.How to verify
Definition of done from #3315:
@databiosphere/findable-uiis on^62.0.0, and the lockfile resolves 62.0.0. (step 1)node -p "require('./node_modules/@databiosphere/findable-ui/package.json').version"afternpm ci. It prints62.0.0.npx tsc --noEmit,npm run lint,npm run check-formatandnpm run build-dev:data-portal. All pass; lint reports 0 errors.npm run devand open/metadata/tier-1. Open the "Required" column filter: focus moves into the panel. Choose "Strongly Recommended": the table shows only those fields. Press Escape: the panel closes and focus returns to the "Required" button./hca-bio-networks/gut/atlases/gut-v1-0/source-datasetsat 1440px. Open the "Assay" filter: the panel opens below the button, aligned to its left edge, with no backdrop, and the page still scrolls. Choose a value: the table filters. Press Escape: focus returns to the button.Plan
package.json, set@databiosphere/findable-uito^61.0.0andkyto^1.10.0, then runnpm installto updatepackage-lock.json.npm auditcounts, runnpm audit fix(without--force), and record the counts again.Deviations
🤖 Generated with Claude Code
🐦 Built with cc-claude-tools