Repository navigation
Fix flakey undulator dcm test #2142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
4ba4f12
Update to ophyd-async v0.20
oliwenmandiamond 7ccbc28
Update naming issue
oliwenmandiamond 8f040e2
Update remaining tests that are not bluesky verb errors
oliwenmandiamond d5c165f
Fix apple2 mock_config:_client errors
oliwenmandiamond 572edb6
update comment
oliwenmandiamond ab0dbcf
Remove unneeded connects
oliwenmandiamond 83d0d5b
Fix fasteiger test
oliwenmandiamond e82b298
Merge branch 'main' into update_to_ophyd_async_0_20
oliwenmandiamond bdbeec8
Update to use 0.21 and use env variable
oliwenmandiamond 377f5d4
Fix ConfigClient issue
oliwenmandiamond 58674a5
Merge branch 'main' into update_to_ophyd_async_0_20
oliwenmandiamond b011acc
Bump ophyd-async pin to >=0.20.1 and fix set_mock_attr test failures
claude dba111c
Remove temporary OPHYD_ASYNC_ALLOW_RESERVED_ATTRS mask
claude 7fc58a4
Fix pyright regression from set_mock_attr changes
claude 2f89975
Merge branch 'main' into update_to_ophyd_async_0_20
oliwenmandiamond 6b424b6
Merge branch 'update_to_ophyd_async_0_20' of ssh://github.com/Diamond…
oliwenmandiamond 96a52b9
Fix flakey undulator dcm test
oliwenmandiamond 8c6f719
Removed event_loop_fuzzing
oliwenmandiamond cc4c9c8
Merge branch 'main' into fix_flakey_undulator_dcm_test
oliwenmandiamond e52ddd9
Merge branch 'main' into fix_flakey_undulator_dcm_test
oliwenmandiamond 36eeeb1
Merge branch 'main' into fix_flakey_undulator_dcm_test
oliwenmandiamond File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: The cause of the flakey test was the timeout being too short, we could have just change it to 0.1 and it would have fixed it.
Or
New code still fail with old timeout:
