Skip to content

Disk stats in Monitoring counts each byte twice #5385

Closed

Description

@jannismilz

To Reproduce

Look at the Monitoring and check /proc/diskstats separately and compare.

Current vs. Expected behavior

Each byte is counted twice because diskstats returns size for a disk and partition which always exists twice.

Only one option should be taken.

Check the code here:

const diskStats = await osutils.disk.stats();

Provide environment information

Ubuntu 26

Which area(s) are affected? (Select all that apply)

Application

Are you deploying the applications where Dokploy is installed or on a remote server?

Same server where Dokploy is installed

Additional context

No response

Will you send a PR to fix it?

No

Activity

  1. linear-code commented on Sep 8, 2026

    @linear-code
  2. breken-ai commented on Sep 9, 2026

    @breken-ai

    @jannismilz Confirmed - /proc/diskstats reports partition I/O in both the partition row and the parent disk row, and getHostSystemStats was summing both, so Block I/O reads ~2x real. Fix is up in #5399: a shouldIncludeDiskStat filter - virtual devices stay excluded, and a partition row is skipped when its parent disk is present (handles sdX1/vdX1 and nvme0n1p1/mmcblk0p1 naming without dropping whole disks like nvme0n1 that end in a digit). Tests cover sd/nvme/mmc naming, virtual devices, and the no-parent edge case.

    Built by breken, your AI support engineer - breken.ai finds the bug, proves the fix with unmatched RCA, answers customers in your voice, and keeps your code and support docs clean - this one's on us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions