Repository navigation
feat(destinations): add Azure Blob Storage backup destination support - #5389
Open
RiadGahlouz wants to merge 5 commits into
Open
RiadGahlouz wants to merge 5 commits into
RiadGahlouz wants to merge 5 commits into
Conversation
- Support Azure Blob Storage (AZ_BS) backups for databases, compose stacks, web server settings, and volumes
- Support Shared Key (Account Name + Key) and Shared Access Signature (SAS URL)
- Add connection string auto-parser helper in destination modal
- Redesign dashboard/settings/destinations UI to Backup Destinations with provider badges and in-row connection test
- Add Rclone credential redaction for Azure keys and SAS tokens
- Generate Drizzle migration 0196_windy_jack_power and update migration journal
- Add 45 automated unit and integration tests
…ners are not found
…ud mode and improve error message redaction
Collaborator
|
I like this feature. This is an automated review and I will personally review this later. Please check the following comments. Review: Azure Blob Storage backup destinationSolid feature design overall (clean Must fix
Should check
Nits
|
…storage-backup # Conflicts: # apps/dokploy/components/dashboard/settings/destination/show-destinations.tsx # apps/dokploy/drizzle/meta/0196_snapshot.json # apps/dokploy/drizzle/meta/_journal.json
Redact shell-quoted secrets that contain mixed quotes, auto-fill container names from pasted SAS URLs, and build rclone remotes from the stored provider instead of sniffing the secret. Missing-container errors now name the storage account from the account key or SAS host. Compose the destination API schemas from the S3 and Azure schemas, reuse getRemotePath on restore, and share Azure type/provider helpers.
|
Are there any updates on this? I would also like to be able to connect to Azure Blob for backups |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR about?
Adds full support for Azure Blob Storage (AZ_BS) as a backup destination alongside S3 / S3-compatible storage, and redesigns the destinations settings interface into Backup Destinations. Key features include:
:azureblob:remote and flag building with credential redaction (--azureblob-key,--azureblob-sas-url).0196_windy_jack_power.sqlwith journal entries and ensures OpenAPI generation compatibility (pnpm generate:openapi).Checklist
Before submitting this PR, please make sure that:
canarybranch.Issues related (if applicable)
closes #3675
The Azure Blob destination changes appear safe to merge, with all previous findings resolved and no actionable new issue established.
Summary
Adds Azure Blob Storage as a first-class backup destination and extends backup and restore execution across databases, Compose services, web-server data, and persistent volumes.
az_bsalias.Reviews (3) · Last reviewed commit: "fix(destinations): address Azure Blob St..."