Repository navigation
Conversation
This comment has been minimized.
This comment has been minimized.
Fixed. Restored hide flag check while keeping backend auto-clear. Hide now works for unused SSO, and the backend prevents the flag staying on when providers are added. |
|
@imrja8 Resolve the conflicts please |
DONE |
20418f3 to
2a2f64b
Compare
2a2f64b to
d847265
Compare
|
Hi @narcisonunez I've pushed a refactor and rebased on canary. Same behaviour as before, much less code. The 5 new toggles and the existing Enforce SSO / Remote Servers Only toggles now render from one component, and the 5 new flags share one mutation. The PR went from about 700 to about 140 net added lines, not counting the generated migration snapshot. On scope: this only works with self-hosted enterprise instances, gated the same way as Enforce SSO and Remote Servers Only.
Why: on a whitelabeled instance, unused Dokploy UI (SSO and passkey buttons, social icons, default help links) still shows to the org's users. These toggles let an admin hide what they don't use, and only while it's unused. To be upfront: this came from my own whitelabeled setup (#5395), and I can't point to other customers asking for it yet. I sent the PR so you can see what it would look like. Happy to drop any toggle you'd rather not have. |
What is this PR about?
The SSO settings page has a "Self-hosted Restrictions" section with Enforce SSO and Remote Servers Only. Many self-hosted enterprise customers use Dokploy for whitelabeling but don't use SSO, passkeys or the default help links, and those buttons and links still show up on their instance.
This PR adds 5 visibility toggles to that section:
1. Hide SSO Button: Hides "Sign in with SSO" on the login page. It can't be turned on while an SSO provider exists or Enforce SSO is on, and registering an SSO provider turns it back off.
2. Hide Documentation Link & Hide Support Link: Hide the default links in the sidebar's "Extra" section, which disappears when both are hidden. Neither can be turned on while a custom URL for that link is set in Whitelabeling, and a custom URL always shows.
3. Hide Social Icons: Hides the GitHub, X and Discord icons on the login, registration, invitation and password reset pages. Uses the
invisibleclass instead of removing them, so the layout doesn't jump.4. Hide Passkey Button: Hides "Sign in with Passkey" on the login page and passkey setup in profile settings. It can't be turned on while any user has a passkey, and users who already have passkeys keep passkey management.
How it works:
webServerSettings, matchingenforceSSOandremoteServersOnly, all defaulting tofalse. Login and other auth pages read them from the public whitelabeling config, since they're unauthenticated.Checklist
Before submitting this PR, please make sure that:
canarybranch.Issues related
Addresses Point 1 (persistent SSO button), Point 3 (hardcoded social icons) and Point 4 (sidebar links) in #5395. Also adds a passkey visibility control.
Screenshots


Confidence Score: 5/5
No new blocking issue was established.Summary
Adds five self-hosted enterprise visibility controls and combines all seven restriction toggles into one component.
The previous commit failed the ancestry and shared-merge-base checks, so this review used the full PR diff. The supplied previous threads have no Comment numbers and therefore have no numbered entries above.
Reviews (4) · Last reviewed commit: "fix(enterprise): list every page Hide So..." · Reviewed by Greptile