Repository navigation
feat(backups): paginate restore file pickers newest first - #5691
lmachineone wants to merge 5 commits into
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
What is this PR about?
Both restore dialogs can browse all matching backup files through bounded newest-first pages, instead of stopping at 100 entries. The new paginated procedure preserves the existing
listBackupFilesarray response, ordering and limit for current callers.--no-mimetype --no-modtime. Each page still enumerates the directory in O(n) and sorts matching entries. Pagination bounds API response counts and incremental rendering, not provider I/O or server memory. Identical-size overwrites cannot be detected without available hashes.Validation
Refreshed against canary
eaffeba4at heade4a96645, using Node 24.22.1 and pnpm 10.22.0.The test job failed only on
__test__/utils/remote-stream.test.ts:43,reports a target failure with its stderr, which timed out after 30 seconds. The run passed 1,584 tests, with one failure and one skip. That test, its process helper, test configuration, dependency manifests, lockfile and CI workflow match canary and the precedinga3323aa9head, whose full test job passed. The subsequent changes only constrain the two restore-form grids and selected-path badges. The timeout cause remains unproven; CI is still failing. A maintainer rerun or separate process-test repair is needed because this account lacks upstream rerun permission.The current-head Codex review returned a generic service error. A manual retry returned the same unknown error. Neither attempt produced actionable findings or a clean review result. Final review clearance remains outstanding.
Checklist
canaryand refreshed against current canary.Issues related
Closes #5688