Repository navigation
Add NOAA/RRFS aerosol variables - #165
huiying-noaa wants to merge 4 commits into
Conversation
|
Gentle ping @dustinswales @svahl991 |
| <standard_name name="mass_fraction_of_dust_coarse_aerosol_particles_in_air" description="Mass fraction of coarse mode dust aerosol particles"> | ||
| <type units="kg kg-1">real</type> | ||
| </standard_name> | ||
| <standard_name name="mass_fraction_of_dust_fine_in_air" description="Mass fraction of PM2p5 portion of dust aerosol particles for NOAA/RRFS"> |
There was a problem hiding this comment.
for NOAA/RRFS shouldn't be in any of these descriptions.
| <standard_name name="mass_fraction_of_dust_fine_in_air" description="Mass fraction of PM2p5 portion of dust aerosol particles for NOAA/RRFS"> | ||
| <type units="kg kg-1">real</type> | ||
| </standard_name> | ||
| <standard_name name="mass_fraction_of_dust_coarse_in_air" description="Mass fraction of (PM10-PM2p5) portion of dust aerosol particles for NOAA/RRFS"> |
There was a problem hiding this comment.
Not entirely sure about the name. Existing ones (e.g. mass_fraction_of_dust_coarse_aerosol_particles_in_air) have coarse/fine (and adjective) to describe a property that follows (coarse_aerosol_particles_in_air). THe way it's written here, it seems to be backwards (coarse dust?). Can we use (coarse|fine)_particles_in_air instead of (coarse|fine)_in_air, and spell out anthropogenic? One below, we also spell out hydrophilic.
There was a problem hiding this comment.
Thanks again for reviewing!
I had the aerosol source name first, followed by the size/range following the existing ones (e.g. mass_fraction_of_dust_coarse_aerosol_particles_in_air).
I initially did not include the aerosol or/and particles to make this new NOAA/RRFS set of names easier to differentiate from the example above from UK MO's variable names, especially that we both have dust_coarse.
I will revise them to the format of mass_fraction_of_dust_fine_particles_in_air, and spell out anthropogenic.
|
Hi @climbfuji, I've updated accordingly and this PR is ready for review again. Many thanks! |
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
Thanks very much, happy with these names.
|
One of the required tests is failing because the names aren't ordered in the way required. From the log:
|
This PR adds 4 aerosol tracers designed for future MPAS-based RRFS at NOAA, as discussed at https://github.com/JCSDA-internal/ufo/pull/4484, https://github.com/JCSDA-internal/vader/pull/429, etc.
I'm little confused by the instructions in the PR template and the README. Could you please review based on this PR and let me know if you have any comments and suggestions to help move this forward? Many thanks!