Repository navigation
Create Source Generator for all options in UI - #457
Merged
Merged
Conversation
initsu
force-pushed
the
ui-source-gen
branch
2 times, most recently
from
October 11, 2026 17:02
a6a22c3 to
48f1b75
Compare
initsu
marked this pull request as draft
October 16, 2026 09:51
initsu
marked this pull request as ready for review
October 17, 2026 17:56
Ellendar
approved these changes
Oct 21, 2026
This generates controls for every flag in RandomizerConfiguration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This generates controls for every flag (and most non-flag checkboxes) in RandomizerConfiguration.
There was a lot of duplicate definitions in the UI, and it relied a lot on reflection. Now we can just write:
Also I can now re-use the controls in my preset diff:

(when you ask yourself if you could, but not if you should)
I also made Vanilla the new default preset, which I believe jroweboy intended to do but never did, or it got lost.
Target: 5.3 probably. Maybe 5.2 but would prefer some feedback first.