Repository navigation
[Due for payment 2026-09-09] [SelectionList ListItem] PR 2 — SelectableListItem adapter + BaseSelectListItem + TravelDomainListItem + CardListItem #98359
Description
Part of the SelectionList ListItem — Composition over Configuration tracking effort. See PR split in this comment.
PR 2 — SelectableListItem adapter + BaseSelectListItem + TravelDomainListItem + CardListItem
- Migrates:
BaseSelectListItem/SingleSelectListItem,TravelDomainListItem,CardListItem.SingleSelectWithAvatarListItem. - Components needed:
SelectableListItemadapter (checkbox/radio viaListSelectionButton, role derived fromcanSelectMultiple, composed onListItem.Pressable);TextColumn. - Deletes:
components/ListCheckbox.tsx,components/ListRadioButton.tsx— pure role-fixing wrappers; callers passrole={CONST.ROLE.CHECKBOX}/{CONST.ROLE.RADIO}onListSelectionButtondirectly. - Implementation details:
- Multiline:
styles.preWrap+ inline{paddingLeft}; muted:styles.colorMuted; subtitlemaxWidthviastyle.
- Multiline:
Activity
roryabraham commentedon Aug 13, 2026
Awaiting PR
melvin-bot commentedon Aug 17, 2026
@jmusial, @roryabraham, @truph01 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon Aug 19, 2026
@jmusial, @roryabraham, @truph01 Eep! 4 days overdue now. Issues have feelings too...
roryabraham commentedon Aug 19, 2026
No update. Still reviewing PR 1
roryabraham commentedon Aug 24, 2026
I approved PR 1 and it's awaiting C+ review.
Looks like @jmusial has a draft PR for this
9 remaining items
roryabraham commentedon Sep 7, 2026
Status update — 2026-09-07
Complete. PR #99177 merged on Sep 1 and was deployed to production in version
9.4.68-1. The issue is in the 7-day regression/payment flow, with payment currently scheduled for Sep 9 if no regression occurs.melvin-bot commentedon Sep 7, 2026
@truph01 Huh... This is 4 days overdue. Who can take care of this?
melvin-bot commentedon Sep 8, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Sep 8, 2026
Payment Summary
Resolving PRs:
SelectableListItem adapter + BaseSelectListItem + TravelDomainListItem + CardListItem #99177
Contributor: @jmusial does not require payment (Contractor)
Reviewer: @truph01 owed $250 via NewDot
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon Sep 10, 2026
@truph01 is this project paid?
truph01 commentedon Sep 11, 2026
@mallenexpensify This will be paid via #97971. You can close it.
MelvinBot commentedon Sep 16, 2026
Status update — 2026-09-16
Complete. SelectableListItem adapter + BaseSelectListItem + TravelDomainListItem + CardListItem merged Sep 1 and deployed. This issue was closed Sep 12.
Bookkeeping only: it still carries
Awaiting PaymentalongsideSkip Payment. Payment for this project runs through the parent tracking issue at$1,000total, so theAwaiting Paymentlabel can come off.Tracking: [$1000] [Tracking] SelectionList ListItem - Composition over Configuration
MelvinBot commentedon Oct 6, 2026
Status update — 2026-10-06
Complete. No change since the last update. SelectableListItem adapter + BaseSelectListItem + TravelDomainListItem + CardListItem merged Sep 1 and is in production. This issue closed Sep 12.
Bookkeeping: this issue still has
Awaiting Paymentnext toSkip Payment. Payment runs once on the tracking issue, so removeAwaiting Payment.Tracking: [$1000] [Tracking] SelectionList ListItem - Composition over Configuration
view run