Feat/439 notification center emails trigger - #142
Conversation
…T_NAMES_V6 overlay. This update introduces comprehensive test cases for various notification events, ensuring correct routing between v6 and legacy activity IDs. The changes aim to improve the reliability of event-triggered emails in the notification service.
…ies and improve event handling This update introduces a new optional parameter `useV6Activities` to the `activityCreator` function, allowing for better routing of notifications between v5 and v6 event handling. The `verified-status` attribute is now conditionally set based on this parameter, ensuring correct email templates are used for different event scenarios. Additionally, the resolution of activity slugs has been updated to utilize `resolveOrttoActivitySlug`, improving the clarity and maintainability of the code. Comprehensive comments have been added to clarify the changes and their implications for event handling.
…ution This commit introduces a new mapping for v6 Ortto activity IDs, allowing for distinct handling of notifications related to v6 events. The `ORTTO_EVENT_NAMES_V6` constant has been added to provide an overlay for v6-specific journeys, ensuring that notifications are routed correctly without affecting legacy v5 events. Additionally, the `resolveOrttoActivitySlug` function has been updated to support the new v6 activities, improving the clarity and maintainability of the notification system. Comprehensive comments have been included to explain the rationale and implications of these changes.
…resolution This update introduces an optional `orttoV6Activities` property to the `SendNotificationRequest` interface. This flag allows for the resolution of events through `ORTTO_EVENT_NAMES_V6`, enabling a transition to v6's Ortto journey while maintaining compatibility with legacy v5 activities. Comprehensive comments have been added to clarify the purpose and usage of this new property.
…idator schema This commit introduces the `orttoV6Activities` property to the `sendNotificationValidator` schema, allowing for the inclusion of v6-specific activity routing. The addition is optional and ensures that unknown keys are rejected, preventing errors in v6 notifications. Comprehensive comments have been added to clarify the purpose and implications of this new flag.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (5)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. WalkthroughThe notification API now accepts an optional Ortto v6 routing flag. A resolver selects v6 or legacy activity slugs. Verification events use v6-specific status attributes. Tests cover activity mappings, fallbacks, trigger ids, and coverage exceptions. ChangesOrtto v6 activity routing
Estimated code review effort: 4 (Complex) | ~45 minutes Suggested reviewers: Merge Risk: ⚪ Minimal · up to This change adds opt-in Ortto v6 notification routing while preserving existing legacy behavior for callers that do not enable it. The current implementation and coverage support merging with normal checks. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit hops through routes of green, Comment |
Summary by CodeRabbit
New Features
Tests