Repository navigation
Test compiled extensions in the conda package - #990
Merged
Merged
Conversation
The recipe test only imported hexrd, which loads none of the compiled extensions. Import them and run the CLI too. Also add the missing dectris-compression dependency that the eiger-stream adapters need. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #990 +/- ##
=======================================
Coverage 75.49% 75.49%
=======================================
Files 149 149
Lines 22985 22985
=======================================
Hits 17353 17353
Misses 5632 5632 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Python 3.10 has reached end of life, and hexrd already uses 3.11-only features (star unpacking in subscripts, typing.NotRequired), so the 3.10 packages could not import imageseries or instrument modules. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
saransh13
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The recipe test only imported hexrd, which loads none of the compiled extensions. Import them and run the CLI too. Also add the missing dectris-compression dependency that the eiger-stream adapters need.
Affected Workflows
Improved packaging tests