Repository navigation
Remove redundant startup reloads and quiet routine lifecycle logs - #14
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reduce startup work and console noise for every FeatureFramework host, including both ServerFeatures and ProxyFeatures.
Root cause
Startup storage preflight created a temporary feature/context and called the full
prepare(...)lifecycle. Managed preparation injects defaults and reloads config/localization. Actual feature activation then creates the real feature/context and runs the same preparation again.That meant routine boot performed two config/localization reload phases per enabled feature and emitted duplicate
Localization files reloaded...INFO messages.Fix
prepareStorage(...)preflight boundary;FeatureHostContext,FeatureLocalization, andFrameworkLoggerimplementations through default methods.Architecture
This deliberately does not merge feature-scoped ORM contexts. Their lifecycle/entity isolation is intentional; startup detail should be quieter without weakening resource ownership boundaries.
The DataProvider ORM/entity/reference-count logging and explicit non-JTA Hibernate bootstrap are handled in the companion DataProvider PR.
Tests
Added regression coverage proving: