Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #938, reported by @HenryZhou19.
With two dictionary config scopes, a newly supplied config update loses its
addedflag because the second scope fills its presets before determining which fixed keys were added. This also bypasses the unused-update check: a misspelled parameter that raisesConfigAddedErrorwith one dictionary scope is silently accepted with two.Move preset filling after the addition/modification summary is collected, matching the ordering already used by
ConfigScope. Add regression tests for the publicConfigDictpreset path and forExperiment.runwith one, two, and three dictionary scopes, covering both consumed and unused new parameters.Validation on Windows, Python 3.11.16, NumPy 2.4.6, and pytest 7.1.2:
python -m pytest tests/ -q -rswith pandas 2.3.3: 726 passed, 12 existing skips.pre-commit run --all-files: Black and Flake8 passed.The current source requires
pkg_resources, so the environment uses setuptools 80.10.2. With pandas 3.0.6, the full suite has the same unrelated TinyDB dataframe-serialization failure on both base and fixed trees; pandas 2.3.3 was used for the passing full run. No dependencies, skips, or CI settings are changed by this PR. Other Python/platform combinations and live observer services were not tested.