[matheuszych]

See: https://mantis.ilias.de/view.php?id=48196

New comments were missing from daily mail notifications because note queries enforced empty obj_type and news_id = 0. The repository now applies those filters only when set, and context loading no longer forces invalid sub-object constraints.

/cc @thojou

[alex40724]

Hi @matheuszych,

Thank you a lot for contributing to ILIAS. The change plausibly fixes the daily-mail query, but I think it introduces a regression for ordinary note views.
Please answer the following question:

• Did you check other affected contexts, e.g. ilDclDetailedViewGUI creates ilCommentGUI($repId, $objId) for a Data Collection record without passing a news ID, so the default news_id = 0 is used. If NoteDBRepository treats that value as “no filter”, the record’s regular comments query can also return comments attached to news items in the same context. This might be an issue for other contexts as well.

Please implement the following change:

• Preserve the news_id = 0 predicate for ordinary contexts. Please limit the wildcard behavior to the daily-mail query, or represent it through a separate explicit query/context option. Otherwise unrelated news comments can appear in normal note views and counts.

Kindly,
@alex40724

[alex40724]

See comment above.

[matheuszych]

Hello @alex40724 ,
thank you for your feedback! I took a look again at the changes and adjusted them according to your suggestions.

Best regards
@matheuszych