Repository navigation
Add functionality required for the GUI - #120
Conversation
24539cf to
31b8968
Compare
|
👋 Hi, @alexhroom, Conflicts have been detected against the base branch. Please rebase your branch against the base branch. This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
afe86a1 to
1db975d
Compare
1db975d to
334d163
Compare
2f8e7fa to
e16950f
Compare
|
👋 Hi, @alexhroom, Conflicts have been detected against the base branch. Please rebase your branch against the base branch. This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
e16950f to
7ce043a
Compare
AnthonyLim23
left a comment
There was a problem hiding this comment.
I think its better testing this in the GUI. However, I wonder if it would might make more sense to add some of this code to the GUI repo, then users wont get it as part of the backend. I am only thinking this because if you picked the GUI to install you are unlikely to run the Python directly and the code is very GUI specific.
|
@AnthonyLim23 I disagree:
|
|
That all make sense to me. I didn't appreciate the extra effort needed with the crate for what is a small change. |
|
@AnthonyLim23 the 'lower effort' alternative to that crate stuff would be if we exposed all the internal data and methods of the code to the Python API, and implemented these methods in Python in the GUI repository. which a.) doesn't fix our problem because we would still have a load of GUI-specific attribute code, and b.) makes the GUI slower because it's doing all this in Python instead of Rust. |
7ce043a to
e9b4004
Compare
This PR adds some extra functionality that was needed for the GUI:
Also fixes a bug where
NexusData.get_frame_times()returned the frame start times as 32-bit integers, which is not big enough for the data and was causing issues with time filter bounds.Fixes #119