Repository navigation
Conversation
…widget instead of trying to resize the parent
yohannd1
reviewed
Nov 1, 2026
yohannd1
left a comment
yohannd1
left a comment
Contributor
There was a problem hiding this comment.
Just tested it, works fine now. I'm confused as to when double clicking stopped working. I remember using it a few times but it's been a while.
Also, see the suggestions. Mostly style fixes.
Contributor
Author
|
Style changes applied |
PhysSong
reviewed
Nov 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8602
The PR also removes m_originalHeight, as the state of the double-click resize is tracked inside the current size of the widget, and refactors the magic number sizes out into constant macro defs