Skip to content

Update Electron to 45.3.1 - #636

Merged
LuqP2 merged 2 commits into
mainfrom
chore/electron-45
Nov 12, 2026
Merged

LuqP2 merged 2 commits into
mainfrom
chore/electron-45

Conversation

@LuqP2

@LuqP2 LuqP2 commented Nov 12, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Upgrade Electron from 38.8.6 to 45.3.1 and refresh its lockfile dependencies.
  • Migrate native clipboard writes for text and PNG images to the async Electron API. Update the Canvas smoke scripts for the new clipboard API.
  • Document macOS 13 (Ventura) as the new minimum. This drops support for macOS 12 (Monterey).

Validation

  • Linux CI passed all 340 test files, lint, and production build.
  • Windows x64 unpacked build passed the packaged Canvas and Prompt Cards smoke, including drag-and-drop, clipboard reads, PNG export, and board persistence. A focused Electron runtime smoke also passed text and PNG clipboard round trips and loaded both app preloads with an isolated profile and a mock ComfyUI view.
  • macOS Intel and Apple Silicon packaging and detached-viewer smoke.
  • The separate Canvas navigation harness printed passing assertions but timed out before the Electron child exited. A live ComfyUI server and the auto-update download and install flow remain unverified.

See the Electron 44 release notes for the clipboard changes and macOS minimum.

@LuqP2
LuqP2 marked this pull request as ready for review November 12, 2026 02:35
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-12T02:37:26.438224Z e2abda0 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@LuqP2
LuqP2 merged commit 1ca1947 into main Nov 12, 2026
5 checks passed
@LuqP2
LuqP2 deleted the chore/electron-45 branch November 12, 2026 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant