Repository navigation
Docs: mean_temp_wall known limitation (particle arrays, high-Mach single-temperature runs) - #2250
Open
sbryngelson wants to merge 1 commit into
Open
sbryngelson wants to merge 1 commit into
sbryngelson wants to merge 1 commit into
Conversation
…gle-temperature runs)
sbryngelson
requested review from
danieljvickers
and removed request for
a team
November 14, 2026 05:34
sbryngelson
marked this pull request as draft
November 14, 2026 05:34
|
Claude Code Review Head SHA: b68adf6 Files changed:
Findings: |
sbryngelson
marked this pull request as ready for review
November 14, 2026 05:41
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a known-limitation note to the
mean_temp_wallparagraph ofdocs/documentation/case.md. In periodic arrays of spheres at 12 cells per diameter the decay ratebetadrifted by more than 1% over the run, and hot-wall and cold-wall runs disagreed; the cause is not understood. A single-wall-temperature run at high Mach number is also biased by viscous heating, which a hot and a cold run cancel to first order. The plane channel (examples/2D_thermal_channel, within 0.1% of the analytic Nu = 7.54) is the validated use.Docs only; no code, parameter or golden changes.
Where the numbers come from
The array drift and the disagreement were observed in development runs of this feature (sphere arrays, 12 cells per diameter) before it merged as #2200; I did not re-run them on current master for this PR, and I did not find the cause. The channel result is the example's own check. The note states the observation and says the cause is unknown; it does not claim a mechanism.
./mfc.sh precheckpasses.This PR was made with Claude Code (AI).