Repository navigation
Tests: regenerate the two IBM reacting-surface Thermostat goldens for #2205 - #2251
Draft
sbryngelson wants to merge 1 commit into
Draft
sbryngelson wants to merge 1 commit into
sbryngelson wants to merge 1 commit into
Conversation
…FlowCode#2205 MFlowCode#2200 added the Thermostat and Thermostat -> Wall Temperature tests with goldens made before MFlowCode#2205 (second-order face composition in the diffusion correction flux) landed, and its CI ran on a base without MFlowCode#2205. On master the two tests miss their goldens by up to 7.7e-6 relative (tolerance 1e-6).
|
Claude Code Review Head SHA: 767b357 Files changed:
Findings: |
sbryngelson
added a commit
to sbryngelson/MFC
that referenced
this pull request
Nov 14, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Regenerates the goldens of the two IBM reacting-surface thermostat tests (
F8D466BDThermostat,C02C399EThermostat -> Wall Temperature) that miss them on master.What failed and why
#2200 added these tests with goldens made before #2205 (second-order face composition in the chemistry diffusion correction flux) landed, and #2200's CI ran on a base without #2205. Both PRs were green on their own bases, so the combination was never tested. On master the two tests miss their goldens by up to 7.7e-6 relative (abs 1.1 on the energy field, tolerance 1e-6), on CPU, NVIDIA and AMD lanes alike.
It is not #2213: on 86eeb34 (#2200 alone) the tests fail with identical numbers, and reverting only
src/common/m_chemistry.fppto its pre-#2205 state on that commit makes both pass against the old goldens.The change is expected: the cases have multicomponent diffusion gradients, which #2205 changes. Largest change of any saved field, relative to that field's maximum: 2.6e-5 (Thermostat) and 3.8e-5 (Wall Temperature), in one species; the conserved-energy-sized fields move by 4e-6 and the rest by 7e-7 or less.
What changed
Only
tests/F8D466BDandtests/C02C399E(golden.txtandgolden-metadata.txt, as generated). No source or tolerance change.Testing
This PR was made with Claude Code (AI).