Skip to content

Tests: regenerate the two IBM reacting-surface Thermostat goldens for #2205 - #2251

Draft
sbryngelson wants to merge 1 commit into
MFlowCode:masterfrom
sbryngelson:fix/thermostat-goldens
Draft

sbryngelson wants to merge 1 commit into
MFlowCode:masterfrom
sbryngelson:fix/thermostat-goldens

Conversation

@sbryngelson

Copy link
Copy Markdown
Member

Summary

Regenerates the goldens of the two IBM reacting-surface thermostat tests (F8D466BD Thermostat, C02C399E Thermostat -> Wall Temperature) that miss them on master.

What failed and why

#2200 added these tests with goldens made before #2205 (second-order face composition in the chemistry diffusion correction flux) landed, and #2200's CI ran on a base without #2205. Both PRs were green on their own bases, so the combination was never tested. On master the two tests miss their goldens by up to 7.7e-6 relative (abs 1.1 on the energy field, tolerance 1e-6), on CPU, NVIDIA and AMD lanes alike.

It is not #2213: on 86eeb34 (#2200 alone) the tests fail with identical numbers, and reverting only src/common/m_chemistry.fpp to its pre-#2205 state on that commit makes both pass against the old goldens.

The change is expected: the cases have multicomponent diffusion gradients, which #2205 changes. Largest change of any saved field, relative to that field's maximum: 2.6e-5 (Thermostat) and 3.8e-5 (Wall Temperature), in one species; the conserved-energy-sized fields move by 4e-6 and the rest by 7e-7 or less.

What changed

Only tests/F8D466BD and tests/C02C399E (golden.txt and golden-metadata.txt, as generated). No source or tolerance change.

Testing

This PR was made with Claude Code (AI).

…FlowCode#2205

MFlowCode#2200 added the Thermostat and Thermostat -> Wall Temperature tests with goldens made before MFlowCode#2205
(second-order face composition in the diffusion correction flux) landed, and its CI ran on a base
without MFlowCode#2205. On master the two tests miss their goldens by up to 7.7e-6 relative (tolerance 1e-6).
@github-actions

Copy link
Copy Markdown

Claude Code Review

Head SHA: 767b357

Files changed:

  • 0

Findings:
No issues found. The prepared diff and changed-files list were empty, so no files were checked in step 4.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant