Repository navigation
Reuse host Nix in CI helper apps - #1177
Merged
Merged
Conversation
Contributor
|
Maple Auth development preview: https://1ba183dc.maple-auth-dev.pages.dev Commit: Uses development services. Cloudflare Access applies. Provider OAuth is not configured for PR URLs; use the stable Auth Dev host for OAuth rehearsal. |
Contributor
|
Maple development preview: https://ef13e7dc.maple-ca8.pages.dev Commit: Uses development API, billing, flags and PCR configuration. Cloudflare Access applies. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nix run .#ci-*helpersnixis unavailable onPATHWhy
The helper apps used
runtimeInputs = [ pkgs.nix ], which silently shadowed the Determinate Nix installed on the host. The current root lock resolvespkgs.nixto 2.31.2+1, so these helpers could re-enter the flake with an older Nix even after the host was upgraded. No lockfile update is needed for this change.Related context: https://github.com/DeterminateSystems/nix-src/releases/tag/v3.23.2
Validation
nix flake check --no-update-lock-file --print-build-logs— all 12 aarch64-darwin checks passed and all 12 Darwin apps validatedci-frontendapp and confirmed its runtime closure contains no Nix packagePATHguard exits 127 with the expected diagnosticnix run --no-update-lock-file .#ci-latest-jsonreached the script through.#ciand then stopped at the intentionally omitted release inputnix develop --no-update-lock-file .#ci -c nix --versionresolved Determinate Nix 3.23.3 / Nix 2.35.3Need help on this PR? Tag
@codesmith-botwith what you need.