Repository navigation
Assert Local API shutdown by owned server task - #1323
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Local API lifecycle tests checked that a released TCP port rejected new connections, or could be rebound. Another parallel fixture can own that address after shutdown, so those checks do not identify the server being tested. The CI rebuild's agent-test job failed at that assertion; the log does not identify which listener accepted the connection.
Capture the original accept task before shutdown and require it to finish. That task owns its listener by value. The real IPC tests also keep a connection accepted before Stop and require EOF/reset after acknowledgement, alongside the existing state and requested-configuration assertions. Apply the same ownership checks to logout, maintenance, Drop and remote Settings tests, and keep never-started ports reserved. The observer is compiled only with
cfg(test); production listener logic is unchanged.Validation:
just cipassed withRUST_TEST_THREADS=4: formatting, metadata checks, four strict Clippy configurations, warning-denied workspace build, workspace tests (including 767 core and 1,092 application tests) and 345 headless tests. Existing ignored tests remain ignored.