Repository navigation
Stabilize Windows updater and integrity test fixtures - #1324
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest master Windows workspace test run fails three updater/lifecycle fixtures: two create a synthetic macOS bundle and ask it to pass Windows installed-root admission, and one expects GPUI restart although Windows uses the stable bootstrap. An earlier Windows run also exhausted the clean integrity fixture's 100 ms budget under load. See the updater/lifecycle failures and integrity budget failure.
Make the controller fixtures hold real OS file locks in the same release-state slot without demanding native admission for a synthetic application. The test guard is compiled only with
cfg(test); production retains the exact updater lock type and ownership. Preserve contention/candidate/state/sentinel checks and add missing-lock rejection plus lock release after controller drop.On Windows, the committed-restart fixture now exercises native bootstrap refusal and retry-state recovery twice, and requires no GPUI restart or premature quit. Existing close/quit and retired-host RPC assertions remain. Give the clean/receipt integrity fixture the same bounded 10-second budget already used by nearby positive fixtures; production budgets and deadline/cancellation negative cases are unchanged.
Validation on macOS with pinned Rust 1.98:
Hosted Windows and broad CI were not awaited; no native Windows result is claimed for this revision. Full application CI/hooks were intentionally waived. No new ignores, assertion removals or automatic retries were added. Production admission, signature, restart and integrity policies remain intact.