Repository navigation
Conversation
…INCT argument or not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MDEV-4167 Register HLL functions and harden HLL value validation
What
Makes the HLL scalar and aggregate functions usable by registering them as
function plugins in
type_hll.so. Also closes gaps where invalid or emptyvalues could reach an
HLLcolumn.Key changes
plugin.cc: addCreate_func_hll<T, ARG_COUNT, AGGREGATE>builder and registerHLL_EMPTY,HLL_CARDINALITY,HLL_CARDINALITY_ROUND,HLL_UNION,HLL_FORMAT_VERSION,HLL_INFO,HLL_BUILD_AGG,HLL_UNION_AGGasMariaDB_FUNCTION_PLUGINs; builditem_hllfunc.ccinto the pluginField_hll::reset(): implicit default isHLL_EMPTY(0x11) instead of anempty string;
.frmdefault record keepsField_blob::reset()Field_hll::store(): on a malformed value, clear the field viaField_blob::reset()and return an errorINSERT IGNOREdoes not turn an invalid HLL into a warning;LOAD DATAresult no longer contains a build-specific pathHow to test
./mysql-test/mtr --suite=type_hll
./plugin/type_hll/hll-t
Based on top of #5573