Skip to content

fix(social): pin the linked-account note above continue - #38048

Merged
aganglada merged 2 commits into
mainfrom
fix/social-link-account-footnote
Oct 22, 2026
Merged

aganglada merged 2 commits into
mainfrom
fix/social-link-account-footnote

Conversation

@andrewchra

@andrewchra andrewchra commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Description

On the social profile onboarding account step, "You can change your linked account every 30 days." sat in the account list, so it floated in the middle of the screen.

The note now lives in the footer, centered, 16px above Continue. It only shows on the account step. The account list keeps the benefits and the account selector.

Changelog

CHANGELOG entry: Moved the linked-account change note to sit above the continue button

Related issues

Fixes: none. Spacing correction from design review, with no tracked issue.

Manual testing steps

Feature: linked account change note

  Scenario: the note sits above continue
    Given the user is on the social profile onboarding account step

    Then "You can change your linked account every 30 days." is centered 16px above Continue
    And the note is not in the list of account benefits

  Scenario: other steps do not show the note
    Given the user is on the username step

    Then the linked-account change note is not shown

Screenshots/Recordings

Before

The 30-day note floating in the account list

After

The 30-day note 16px above Continue

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
UI layout and test-only updates on social onboarding; no auth, data, or linking logic changes.

Overview
On social profile onboarding’s account step, the “You can change your linked account every 30 days.” copy no longer sits with the benefit list in the middle of the screen.

LinkedAccountPicker is wrapped in a flex-1 column: selector and checkmark benefits stay at the top, while the footnote uses mt-auto and stays centered so it anchors toward the bottom of the step (above Continue). The account step container in SocialProfileOnboardingView also gets flex-1 so that layout can fill the step.

Adds ACCOUNT_CHANGE_FOOTNOTE test ID and a view test that the footnote shows the expected copy on the account step.

Reviewed by Cursor Bugbot for commit f2f699b. Bugbot is set up for automated code reviews on this repo. Configure here.

The 30-day note sat in the account list, so it floated in the middle of the
screen instead of staying with the continue button.

Co-authored-by: Cursor <cursoragent@cursor.com>
@andrewchra andrewchra added the team-social-ai Social & AI team label Oct 22, 2026
@andrewchra andrewchra self-assigned this Oct 22, 2026
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions Bot added size-S pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. labels Oct 22, 2026
@andrewchra andrewchra removed the pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. label Oct 22, 2026
@andrewchra
andrewchra marked this pull request as ready for review October 22, 2026 14:37
@andrewchra
andrewchra requested a review from a team as a code owner October 22, 2026 14:37
@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Smart E2E Test Selection

AI Confidence: 92

E2E reasoning

Expand to read

The PR makes minor UI layout changes to the SocialLeaderboard ProfileOnboarding feature:

  1. LinkedAccountPicker.tsx: Refactored layout to move a footnote text element outside the inner Box gap={4} container to the bottom of the component, added twClassName="flex-1" to the outer wrapper, and added a testID (ACCOUNT_CHANGE_FOOTNOTE) to the footnote. This is a purely cosmetic/layout fix to position the footnote at the bottom of the screen.

  2. SocialProfileOnboardingView.tsx: Added twClassName="flex-1" to the account step Box — a one-line layout fix.

  3. SocialProfileOnboardingView.testIds.ts: Added a new ACCOUNT_CHANGE_FOOTNOTE constant.

  4. SocialProfileOnboardingView.view.test.tsx: Added a test assertion verifying the footnote text content.

Why no E2E tags are selected:

  • None of the available E2E smoke tags cover the Social Leaderboard / Profile Onboarding flow. This feature is not part of SmokeAccounts, SmokeConfirmations, SmokeWalletPlatform, SmokeSwap, SmokeStake, SmokeMoney, SmokePerps, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeMultiChainAPI, SmokePredictions, SmokeSeedlessOnboarding, SmokeBrowser, SmokeSnaps, or SmokeMMConnect.
  • The changes are isolated to a single feature component with no shared infrastructure impact.
  • The changes are additive (new test ID, new test assertion) plus minor layout tweaks with no behavioral changes to existing flows.
  • The component view test (*.view.test.tsx) already covers this change at the integration test level.
  • Risk is low: blast radius is limited to the SocialLeaderboard ProfileOnboarding screen only.

Performance reasoning

Expand to read

The changes are minor UI layout adjustments (adding flex-1 to Box containers, repositioning a footnote text element) within the SocialLeaderboard ProfileOnboarding feature. These changes do not affect any performance-sensitive flows such as account list rendering, onboarding performance, login, swaps, app launch, asset loading, predictions, perps, money, or rewards. No performance test tags are warranted.

View run

Keep the 30-day note in the account picker and stretch that picker down to
the continue button, so the note sits 16px above it.

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions github-actions Bot added size-M and removed size-S labels Oct 22, 2026
@sonarqubecloud

Copy link
Copy Markdown

@aganglada
aganglada added this pull request to the merge queue Oct 22, 2026
Merged via the queue into main with commit 31a394d Oct 22, 2026
90 checks passed
@aganglada
aganglada deleted the fix/social-link-account-footnote branch October 22, 2026 17:42
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 22, 2026
@metamask-ci metamask-ci Bot added the release-8.18.0 Issue or pull request that will be included in release 8.18.0 label Oct 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-8.18.0 Issue or pull request that will be included in release 8.18.0 size-M team-social-ai Social & AI team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants