Repository navigation
fix: model save directly after validation - #3605
Merged
Merged
Conversation
Signed-off-by: Teodor-Dumitru Ene <teodord.ene@gmail.com>
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test b9dad68 |
cspades
approved these changes
Aug 13, 2026
cspades
left a comment
cspades
left a comment
Contributor
There was a problem hiding this comment.
when it is called during colocated, right after a validation run, the model is not on GPU, because ...
The inference model is used for validation?
shanmugamr1992
approved these changes
Aug 13, 2026
yuki-97
reviewed
Aug 14, 2026
tdene
added
CI:Lfast
yuki-97
enabled auto-merge (squash)
August 14, 2026 12:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
save_checkpointassumes the training model is on GPU. But when it is called during colocated, right after a validation run, the model is not on GPU.This is probably best fixed with a bigger refactor, but this PR prevents crashes. Optimizations beyond that are not a priority due to how rare this issue is.
Issues
List issues that this PR closes (syntax):
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information