Conversation
parse_meta read input:[1,2 as shape [1, 2]. A list now has to start with '[' and end with ']', with no extra brackets. Signed-off-by: Sasha Mitchell <sash.t.mitchell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Closes #4864.
cast()removed brackets withstr.strip("[]"). That drops any[or]from either end, so a shape does not have to be a matched pair.parse_meta("input:[1,2", includes_dtype=False)returned shape[1, 2]. The same wrong shape came back for1,2],]1,2[, and[1,2]].A list now has to start with
[and end with], and the inside cannot contain another bracket.[],[1,2],[1,2,],[-1,2], and["batch",3]stay valid.Testing
pytest --noconftest tests/tools/args/util/test_util.py: 46 passed.On main, the four unbalanced shapes above each returned
[1, 2]. After this change they raisePolygraphyException.Drafted with Grok 4.7. The code has not yet been reviewed by a human.